Skip to content

Change top_k to be disabled with 0 (still accept -1 for now)#17773

Merged
DarkLight1337 merged 3 commits into
vllm-project:mainfrom
hmellor:topk-0
May 9, 2025
Merged

Change top_k to be disabled with 0 (still accept -1 for now)#17773
DarkLight1337 merged 3 commits into
vllm-project:mainfrom
hmellor:topk-0

Conversation

@hmellor

@hmellor hmellor commented May 7, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This better matches Hugging Face, the main other place top_k is used.

Closes #17553.

@hmellor
Change top_k to be disabled with 0 (still accept -1 for now)
0b13b87 
This better matches Hugging Face, the main other place `top_k` is used.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify Bot added frontend tpu Related to Google TPUs labels May 7, 2025
@hmellor hmellor mentioned this pull request May 7, 2025
Closed
DarkLight1337
DarkLight1337 reviewed May 7, 2025
View reviewed changes
Comment thread vllm/worker/tpu_model_runner.py Outdated
@hmellor
Update condition based on feedback
46ad416 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor requested a review from DarkLight1337 May 8, 2025 11:58
NickLucche
NickLucche approved these changes May 9, 2025
View reviewed changes

@NickLucche NickLucche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this also better matches the behavior in V1

DarkLight1337
DarkLight1337 approved these changes May 9, 2025
View reviewed changes

@DarkLight1337 DarkLight1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 9, 2025 08:08
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 9, 2025
@DarkLight1337 DarkLight1337 merged commit c6798ba into vllm-project:main May 9, 2025
72 checks passed
@hmellor hmellor deleted the topk-0 branch May 9, 2025 11:32
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@hmellor @princepride
Change top_k to be disabled with 0 (still accept -1 for now) (v…
d689a9b 
…llm-project#17773)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Change top_k to be disabled with 0 (still accept -1 for now) (v…
865088c 
…llm-project#17773)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@hmellor @mawong-amd
Change top_k to be disabled with 0 (still accept -1 for now) (v…
50ec6f3 
…llm-project#17773)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Change top_k to be disabled with 0 (still accept -1 for now) (v…
2c6ad70 
…llm-project#17773)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
@albertvillanova albertvillanova mentioned this pull request Dec 15, 2025
Merged
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@hmellor
Change top_k to be disabled with 0 (still accept -1 for now) (v…
1e01d61 
…llm-project#17773)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill njhill left review comments

@NickLucche NickLucche NickLucche approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: top_k: 0 in generation_config.json can't disable top-k sampling

4 participants

@hmellor @NickLucche @njhill @DarkLight1337