Skip to content

Override vLLM classes for PP#1401

Merged
Chenyaaang merged 4 commits into
mainfrom
chenyangli/pp-multiproc
Jan 21, 2026
Merged

Override vLLM classes for PP#1401
Chenyaaang merged 4 commits into
mainfrom
chenyangli/pp-multiproc

Conversation

@Chenyaaang

@Chenyaaang Chenyaaang commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

Description

Changes related to PP according to vLLM upstream PR vllm-project/vllm#28506.

  • Create MultiprocExecutor class for TPU to support MPMD in Pipeline Parallelism, while keeping SPMD for the rest parallelisms (TP, DP, CP, EP). The class inherits vllm's MultiprocExecutor
  • Create RayWorkerWrapper to support Jax intermediate tensor for PP. The class inherits vllm's RayWorkerWrapper
  • Patch vLLM's get_pp_group with Jax's get_pp_group in vllm_model_wrapper.py
  • Update tests

Tests

Verified PP E2E test passed on both torchax and Jax models.
Tested CI (using the tpu_inference changes + PP forked branch in vllm) passed: https://buildkite.com/tpu-commons/tpu-inference-ci/builds/8192

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@Chenyaaang Chenyaaang force-pushed the chenyangli/pp-multiproc branch 3 times, most recently from 80cc2b0 to 8a322de Compare January 8, 2026 21:49
@Chenyaaang Chenyaaang changed the title override vllm multiproc executor Override vLLM classes for PP Jan 13, 2026
@Chenyaaang Chenyaaang force-pushed the chenyangli/pp-multiproc branch from 86a91d4 to fbfe823 Compare January 14, 2026 05:30
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
@Chenyaaang Chenyaaang added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 20, 2026

@yaochengji yaochengji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Chenyaaang Chenyaaang merged commit b01dbfe into main Jan 21, 2026
8 of 9 checks passed
lorriexingfang pushed a commit to lorriexingfang/tpu-inference that referenced this pull request Feb 26, 2026
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Xing Fang <xing.fang@anyscale.com>
@wdhongtw wdhongtw deleted the chenyangli/pp-multiproc branch April 7, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants