Override vLLM classes for PP#1401
Merged
Merged
Conversation
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
80cc2b0 to
8a322de
Compare
86a91d4 to
fbfe823
Compare
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
8733792 to
8bd2ad9
Compare
lorriexingfang
pushed a commit
to lorriexingfang/tpu-inference
that referenced
this pull request
Feb 26, 2026
Signed-off-by: Chenyaaang <chenyangli@google.com> Signed-off-by: Xing Fang <xing.fang@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes related to PP according to vLLM upstream PR vllm-project/vllm#28506.
MultiprocExecutorclass for TPU to support MPMD in Pipeline Parallelism, while keeping SPMD for the rest parallelisms (TP, DP, CP, EP). The class inherits vllm's MultiprocExecutorget_pp_groupwith Jax'sget_pp_groupinvllm_model_wrapper.pyTests
Verified PP E2E test passed on both torchax and Jax models.
Tested CI (using the tpu_inference changes + PP forked branch in vllm) passed: https://buildkite.com/tpu-commons/tpu-inference-ci/builds/8192
Checklist
Before submitting this PR, please make sure: