Skip to content

[Mellanox] Add support for SN4280 platform#94

Closed
vivekrnv wants to merge 22 commits intomasterfrom
sn4280_platform
Closed

[Mellanox] Add support for SN4280 platform#94
vivekrnv wants to merge 22 commits intomasterfrom
sn4280_platform

Conversation

@vivekrnv
Copy link
Copy Markdown
Owner

@vivekrnv vivekrnv commented Apr 12, 2024 •
edited
Loading

Why I did it

Add support for SN4280 platform

Port configuration Value
Breakout mode for each port Defined in port mapping
Speed of the port Defined in Port mapping
Internal Ports Defined in Port mapping
Buffer configuration Value
Shared headroom Enabled
Shared headroom pool factor 2
Dynamic Buffer Disable
In static buffer scenario how many uplinks and downlinks? 8 1x400G uplinks and 20 1x400G downlinks, 4 1x400G downlink Internal ports

Port Mapping

Ports Mode
1-8 1x400G
9-28 1x400G
28-32 1x400G (Internal Ports connected to DPU)

Number of Uplinks / Downlinks:

Default topology: T1

T1-T2: 2000m
T0-T1: 300m
T0-server: 40m

How I did it

How to verify it

Verified by running regression on SN4280 platform

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vivekrnv vivekrnv requested a review from dgsudharsan as a code owner May 28, 2024 20:18
vivekrnv and others added 3 commits May 28, 2024 20:21
@vivekrnv
[Mellanox] Add support for SN4280 platform
1751bb6 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Remove deprecated SFP sensors from sensors.conf
83935e3 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Update pcie.yaml after discovering DPU4
3ef8f2f
@vivekrnv vivekrnv changed the title [Nvidia] Add support for SN4280 [Mellanox] Add support for SN4280 May 28, 2024
@vivekrnv
Fixed outdated header
6e99dae 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
dgsudharsan
dgsudharsan requested changes May 29, 2024
View reviewed changes
Comment thread device/mellanox/x86_64-nvidia_sn4280-r0/ACS-SN4280/sai.profile Outdated
dgsudharsan
dgsudharsan requested changes May 29, 2024
View reviewed changes
Comment thread device/mellanox/x86_64-nvidia_sn4280-r0/ACS-SN4280/README.md Outdated
Comment thread device/mellanox/x86_64-nvidia_sn4280-r0/ACS-SN4280/sai_4280.xml Outdated
Comment thread device/mellanox/x86_64-nvidia_sn4280-r0/ACS-SN4280/sai_4280.xml
@vivekrnv vivekrnv changed the title [Mellanox] Add support for SN4280 [Mellanox] Add support for SN4280 platform May 29, 2024
vivekrnv and others added 11 commits May 31, 2024 09:41
@vivekrnv
Remove Redundant files in SKU definition
243da09 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Add Mellanox-SN4280-O28 SKU
7e8fdf3 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@Yakiv-Huryk @vivekrnv
[mellanox] extend cpld logic for x86_64-nvidia_sn4280-r0 (sonic-net#345)
cc07d86 
* add DPU FPGA support
* add SN4280 CPLD support
@vivekrnv
Update sensors.conf based on latest hw-mgmt
4336af0 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Fix pool xoff and size for SN4280 SKU
6363772 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Fix onie version parsing issue in platform api
bdc39a4 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Update platform.json with new thermal list
7e975c5
@Yakiv-Huryk @vivekrnv
[mellanox] fix DPU fpga update (sonic-net#350)
64b97e9 
* update cpldupdate command line
@oleksandrivantsiv @vivekrnv
[mellanox] Add DPUs sersion to x86_64-nvidia_sn4280-r0 platform.
9104c6e
@vivekrnv
Disable mlx5_core and mlx5_ib drivers for SN4280 (sonic-net#352)
10bf201 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Update local port and module mapping in sai xml
9ea83fc 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv vivekrnv requested a review from dgsudharsan June 10, 2024 18:46
@vivekrnv
Copy link
Copy Markdown
Owner Author

vivekrnv commented Jun 10, 2024

@stephenxs Please review buffer changes

@stephenxs
Copy link
Copy Markdown

stephenxs commented Jun 10, 2024

@stephenxs Please review buffer changes

Hi @vivekrnv
we probably need to update headroom (pg_profile_lookup.ini) file starting from this SKU.
I'm asking @baiwei0427 to provide the proper percentage to use.
Will get back to you once I have an answer

@stephenxs
Copy link
Copy Markdown

stephenxs commented Jun 11, 2024

@stephenxs Please review buffer changes

Hi @vivekrnv we probably need to update headroom (pg_profile_lookup.ini) file starting from this SKU. I'm asking @baiwei0427 to provide the proper percentage to use. Will get back to you once I have an answer

50%.

@vivekrnv
Update pg profile and add missing symbolic link for qos config
86cf0df 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Copy link
Copy Markdown
Owner Author

vivekrnv commented Jun 11, 2024

@stephenxs Please review buffer changes

Hi @vivekrnv we probably need to update headroom (pg_profile_lookup.ini) file starting from this SKU. I'm asking @baiwei0427 to provide the proper percentage to use. Will get back to you once I have an answer

Hi, Updated the values. please check

vivekrnv added 2 commits June 11, 2024 23:54
@vivekrnv
Round up xoff values in pg profile based on KB
6a75738 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Round xoff values to next highest integer
7c2393b 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@stephenxs
Copy link
Copy Markdown

stephenxs commented Jun 14, 2024

buffer pool sizes LGTM. How does it guarantee the cable length is deployed the expected cable length? currently, the default value differs. see https://github.com/sonic-net/sonic-buildimage/blob/master/files/build_templates/buffers_config.j2#L41

@vivekrnv
Encode default cable lengths required for deployment
fe9ebb5 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
oleksandrivantsiv and others added 2 commits June 14, 2024 04:21
@oleksandrivantsiv @vivekrnv
Update pcie.yaml after updating BF FW configuration
9da7fc4
@vivekrnv
Fix headers
2a73a28 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv vivekrnv closed this Jun 14, 2024
vivekrnv pushed a commit that referenced this pull request Jul 31, 2025
@mssonicbld
[submodule] Update submodule sonic-dash-ha to the latest HEAD automat…
8f662a5 
…ically (sonic-net#23516)

#### Why I did it
src/sonic-dash-ha
```
* 901c374 - (HEAD -> master, origin/master, origin/HEAD) move Semgrep to workflows directory (#94) (4 hours ago) [Mai Bui]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

+1 more reviewer

@stephenxs stephenxs stephenxs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vivekrnv @stephenxs @dgsudharsan @Yakiv-Huryk @oleksandrivantsiv