fix(vitest): use `fast-glob` instead of `tinyglobby` in Vitest by sheremet-va · Pull Request #6688 · vitest-dev/vitest

sheremet-va · 2024-10-11T10:06:59Z

Description

The team decided to revert to fast-glob until the symlink issue is resolved.

We are keeping the tinyglobby package in other dependencies.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2024-10-11T10:09:49Z

✅ Deploy Preview for vitest-dev ready!

Name	Link
🔨 Latest commit	`44e0ae2`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/6708f8c5c2d3b900087c50d0
😎 Deploy Preview	https://deploy-preview-6688--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hi-ogawa

Thanks!

@hi-ogawa

##### [v2.1.3](https://github.com/vitest-dev/vitest/releases/tag/v2.1.3) ##### 🐞 Bug Fixes - Fix error diff of `toBeNaN, toBeUndefined, toBeNull, toBeTruthy, toBeFalsy` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6697 [<samp>(e0027)</samp>](vitest-dev/vitest@e002758c) - **browser**: - Provide aria role intellisense - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6629 [<samp>(f36ea)</samp>](vitest-dev/vitest@f36eac77) - Not.toBeInTheDocument works with locators API - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6634 [<samp>(8bef5)</samp>](vitest-dev/vitest@8bef5d2b) - Use `/mockServiceWorker.js` instead of `/__vitest_msw__` - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6687 [<samp>(4b2ce)</samp>](vitest-dev/vitest@4b2ce07f) - Don't override the esbuild option in the browser mode - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6692 [<samp>(d131f)</samp>](vitest-dev/vitest@d131fd64) - **expect**: - Preserve prototype in `toMatchObject` diff - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6620 [<samp>(d289e)</samp>](vitest-dev/vitest@d289e7eb) - **mocker**: - Specify correct spy dependency - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(7e958)</samp>](vitest-dev/vitest@7e9584aa) - **runner**: - Ensure sequential suite overrides sequence.concurrent - by [@dsyddall](https://github.com/dsyddall) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6653 [<samp>(5e6de)</samp>](vitest-dev/vitest@5e6de274) - **vitest**: - Deprecate UserConfig in favor of ViteUserConfig - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6626 [<samp>(496bd)</samp>](vitest-dev/vitest@496bd251) - Don't hang with maxConcurrency 0 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6627 [<samp>(946d8)</samp>](vitest-dev/vitest@946d8bb1) - Deprecate old task types and node-reliant types - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6632 [<samp>(00045)</samp>](vitest-dev/vitest@000459a9) - Fix `<empty line>` logs when interleaving `console.log/error` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6644 [<samp>(9ece3)</samp>](vitest-dev/vitest@9ece3952) - Show rollup error details as test error - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6686 [<samp>(47dde)</samp>](vitest-dev/vitest@47dde76f) - Always inline setup files - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6689 [<samp>(19d64)</samp>](vitest-dev/vitest@19d64e20) - Use `fast-glob` instead of `tinyglobby` in Vitest - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6688 [<samp>(70baa)</samp>](vitest-dev/vitest@70baaaa9) - **web-worker**: - Share mocker with main executor - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6623 [<samp>(fe7b8)</samp>](vitest-dev/vitest@fe7b8aee) ##### 🏎 Performance - Reuse full name in reported tasks, update generator types - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6666 [<samp>(7a0de)</samp>](vitest-dev/vitest@7a0de0a7) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.2...v2.1.3)

SuperchupuDev · 2024-10-25T07:47:00Z

@sheremet-va the symlinks issue should be solved now in 0.2.10

benmccann · 2024-10-31T14:42:46Z

It looks like @hi-ogawa has a PR out for some work using tinyglobby: #6600. Hopefully if it is switched from the pkg.pr.new version to the released version everything should work

hi-ogawa · 2024-11-01T01:33:16Z

@SuperchupuDev Hi, thanks for the fix! We went with reverting tinyglobby for now, but we plan to revisit in next major or minor releases. We had a few back and forth with the transition, so we'll just hold off for a moment. I appreciate what you do with tinyglobby 🙏

benmccann · 2024-11-10T05:02:13Z

Is there anything we could help with to get it working in one of the upcoming minor releases?

benmccann · 2024-12-08T22:50:10Z

Vite 6 is out now, which migrated from fast-glob to tinyglobby (changelog). I wonder if that might make it a good time to try again here?

hi-ogawa · 2024-12-08T23:44:34Z

Yeah, we can bring back tinyglobby for Vitest v3. Please feel free to send a PR 👍

…t-dev#6688)

fix(vitest): use fast-glob instead of tinyglobby in Vitest

44e0ae2

sheremet-va requested a review from hi-ogawa October 11, 2024 10:07

sheremet-va added 2 commits October 11, 2024 13:13

chore: errors order

dde52e5

test: fix browser check

ca74e5e

hi-ogawa approved these changes Oct 12, 2024

View reviewed changes

hi-ogawa merged commit 70baaaa into vitest-dev:main Oct 12, 2024

renovate bot mentioned this pull request Oct 14, 2024

Update all non-major dependencies YannicEl/mailer#75

Merged

1 task

hi-ogawa mentioned this pull request Nov 1, 2024

chore(deps): update tinyglobby and use isDynamicPattern #6600

Closed

6 tasks

sheremet-va deleted the fix/revert-tyinyglobby branch November 3, 2024 20:25

nerdy-tech-com-gitub mentioned this pull request Nov 6, 2024

[Snyk] Upgrade @vitest/coverage-v8 from 1.6.0 to 2.1.3 nerdy-tech-com-gitub/starlight#15

Open

This was referenced Nov 15, 2024

chore(deps): update all non-major dependencies wattanx/nuxt-vuex-module#36

Merged

chore(deps): update all major updates (major) - autoclosed productdevbook/chatwoot#58

Closed

benmccann mentioned this pull request Dec 19, 2024

chore: use tinyglobby instead of fast-glob in Vitest #7105

Closed

6 tasks

ronami mentioned this pull request Dec 23, 2024

Enhancement: replace fast-glob with tinyglobby typescript-eslint/typescript-eslint#10533

Closed

4 tasks

renovate bot mentioned this pull request Jan 7, 2025

chore(deps): update all non-major dependencies marimo-team/vscode-marimo#59

Closed

1 task

ziltoidbot mentioned this pull request Jan 16, 2025

chore(deps): update dependency vitest to v3 mailerlite/mailerlite-nodejs#66

Closed

1 task

doyobot bot mentioned this pull request Jan 20, 2025

chore(deps): update dependency vitest to v3 kilip/doyokit#8

Merged

1 task

benmccann mentioned this pull request Feb 16, 2025

chore: use tinyglobby instead of fast-glob in Vitest #7504

Merged

6 tasks

spamshaker pushed a commit to spamshaker/vitest that referenced this pull request Jun 30, 2025

fix(vitest): use fast-glob instead of tinyglobby in Vitest (vites…

0a21d9c

…t-dev#6688)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(vitest): use `fast-glob` instead of `tinyglobby` in Vitest#6688

fix(vitest): use `fast-glob` instead of `tinyglobby` in Vitest#6688
hi-ogawa merged 3 commits intovitest-dev:mainfrom
sheremet-va:fix/revert-tyinyglobby

sheremet-va commented Oct 11, 2024

Uh oh!

netlify bot commented Oct 11, 2024

Uh oh!

hi-ogawa left a comment

Uh oh!

SuperchupuDev commented Oct 25, 2024

Uh oh!

benmccann commented Oct 31, 2024

Uh oh!

hi-ogawa commented Nov 1, 2024

Uh oh!

benmccann commented Nov 10, 2024

Uh oh!

benmccann commented Dec 8, 2024

Uh oh!

hi-ogawa commented Dec 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

sheremet-va commented Oct 11, 2024

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

netlify bot commented Oct 11, 2024

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa left a comment

Choose a reason for hiding this comment

Uh oh!

SuperchupuDev commented Oct 25, 2024

Uh oh!

benmccann commented Oct 31, 2024

Uh oh!

hi-ogawa commented Nov 1, 2024

Uh oh!

benmccann commented Nov 10, 2024

Uh oh!

benmccann commented Dec 8, 2024

Uh oh!

hi-ogawa commented Dec 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants