Skip to content

fix(browser): disable client cdp API when allowWrite/allowExec: false [backport to v3]#10456

Merged
sheremet-va merged 3 commits into
vitest-dev:v3from
hi-ogawa:backport-v3-browser-cdp-api-permissions
May 28, 2026
Merged

fix(browser): disable client cdp API when allowWrite/allowExec: false [backport to v3]#10456
sheremet-va merged 3 commits into
vitest-dev:v3from
hi-ogawa:backport-v3-browser-cdp-api-permissions

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa mentioned this pull request May 26, 2026
Merged
8 tasks
@netlify

netlify Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0571306
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a1692e0d5c6d7000855de4e
😎 Deploy Preview https://deploy-preview-10456--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa mentioned this pull request May 27, 2026
Merged
7 tasks
@hi-ogawa

hi-ogawa commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

I will rebase this after #10445

@hi-ogawa hi-ogawa marked this pull request as ready for review May 28, 2026 02:53
@sheremet-va

sheremet-va commented May 28, 2026

Copy link
Copy Markdown
Member

conflict 😢

hi-ogawa and others added 3 commits May 28, 2026 17:37
@hi-ogawa @codex
fix(browser): gate cdp behind api permissions
1195708 
Co-authored-by: Codex <noreply@openai.com>
@hi-ogawa
chore: lint
c22d530
@hi-ogawa @codex
test(browser): cover cdp api permissions backport
9b6e1c3 
Co-authored-by: Codex <noreply@openai.com>
@hi-ogawa hi-ogawa force-pushed the backport-v3-browser-cdp-api-permissions branch from 0571306 to 9b6e1c3 Compare May 28, 2026 08:39
@hi-ogawa hi-ogawa requested a review from sheremet-va May 28, 2026 09:45
@sheremet-va sheremet-va merged commit 385a1ae into vitest-dev:v3 May 28, 2026
17 of 26 checks passed
@hi-ogawa hi-ogawa deleted the backport-v3-browser-cdp-api-permissions branch May 29, 2026 00:52
@t1m0thyj t1m0thyj mentioned this pull request Jun 3, 2026
Open
@CataldoMazzilli CataldoMazzilli mentioned this pull request Jun 5, 2026
Merged
@benjih benjih mentioned this pull request Jun 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va Awaiting requested review from sheremet-va

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hi-ogawa @sheremet-va