feat(api): add allowWrite and allowExec options to api [backport to v3]#10445
Conversation
allowWrite and allowExec options to api (backport v3)allowWrite and allowExec options to api (backport v3.1)
allowWrite and allowExec options to api (backport v3.1)allowWrite and allowExec options to api (backport v3)
allowWrite and allowExec options to api (backport v3)allowWrite and allowExec options to api [backport to v3]
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
33608f1 to
33f3f21
Compare
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
@pmaieref Thanks for the ping. The advisory has been updated. |
|
@hi-ogawa Follow up question regarding the advisory DB: This page states that version 3.2.5 includes a fix for the CVE. However Github's reviewed DB still only includes 4.1.0. Could this be the reason why my SBOM scanner still does not recognize it as fixed even though I installed version 3.2.6? Is there a way to trigger a new review? |
|
@ingk I'm not familiar with the process, but Github side likely needs to reflect the update through https://github.com/github/advisory-database. There's one PR there github/advisory-database#7881. |
|
@hi-ogawa Thanks, that's good to know! I will watch the PR for the advisory database. |
Description
This PR backports the
allowWrite/allowExechardening from #9350 to the v3 branch for GHSA-5xrq-8626-4rwp. Since v3 and v4 have diverged code, this was ported manually rather than as a direct cherry-pick.Notable divergences:
isFileLoadingAllowedusage; v3 keepsisFileServingAllowedand only normalizes concrete file paths withslash(...). For the concrete file paths Vitest checks here, that should preserve the relevant protection.TODO
(but release should wait for another v3 backport fix(browser): disable client
cdpAPI whenallowWrite/allowExec: false[backport to v3] #10456)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.