Skip to content

fix(browser): fix trace highlight of shadow dom on webdriverio#10227

Merged
hi-ogawa merged 3 commits intovitest-dev:mainfrom
hi-ogawa:fix-browser-fix-trace-highlight-of-shadow-dom-on-webdriverio
Apr 29, 2026
Merged

fix(browser): fix trace highlight of shadow dom on webdriverio#10227
hi-ogawa merged 3 commits intovitest-dev:mainfrom
hi-ogawa:fix-browser-fix-trace-highlight-of-shadow-dom-on-webdriverio

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Apr 29, 2026 •
edited
Loading

Description

Follow up fix of #10212. SerializedLocator.selector isn't usable for querying shadow dom on non playwright provider. This extends SerializedLocator._pwSelector to preserve query understood by ivya.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 29, 2026

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2268406
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69f15bb71e5ce100089554ca
😎 Deploy Preview https://deploy-preview-10227--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa
hi-ogawa commented Apr 29, 2026
View reviewed changes
Comment thread test/browser/specs/trace.test.ts
"snapshot": {
"selectorError": "Unexpected token "" while parsing selector """,
"selectorResolution": "error",
"selectorResolution": "matched",
Copy link
Copy Markdown
Collaborator Author

@hi-ogawa hi-ogawa Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix

@hi-ogawa hi-ogawa marked this pull request as ready for review April 29, 2026 01:39
@hi-ogawa hi-ogawa merged commit b01afd2 into vitest-dev:main Apr 29, 2026
16 of 17 checks passed
@hi-ogawa hi-ogawa deleted the fix-browser-fix-trace-highlight-of-shadow-dom-on-webdriverio branch April 29, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trace view - Improve trace step by preserving original user-facing locator presentation

2 participants

@hi-ogawa @sheremet-va