fix!: represent locator as an object instead of a string#10212
Merged
sheremet-va merged 21 commits intovitest-dev:mainfrom Apr 28, 2026
Merged
fix!: represent locator as an object instead of a string#10212sheremet-va merged 21 commits intovitest-dev:mainfrom
sheremet-va merged 21 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
reviewed
Apr 28, 2026
| // resolved server-side from stack in __vitest_recordBrowserTrace command | ||
| location?: { file: string; line: number; column: number } | ||
| selector?: string | ||
| element?: SerializedLocator |
Collaborator
There was a problem hiding this comment.
This looks good. The change should be already verifiable by updating snapshot of test/browser/specs/trace.test.ts. UI side wiring is just TraceView.vue and just manual testing is enough.
This was referenced Apr 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
asLocatoris re-exported from the Node entry point which bundlesivyatwice (in the browser and node). To fix that, we now include thelocatorstring in the JSON message. This is a breaking change since commands now receive an object instead of a string.