Merged
Conversation
Re-using the keyspace.Keyspace object, as it has what we need, until we use the proto3 version.
(note we only test a couple methods, so it's not there yet).
go/vt/vtgate/vtgate.go
Outdated
Contributor
There was a problem hiding this comment.
I feel it is better not to mix with v3 component ("router").
Contributor
Author
There was a problem hiding this comment.
Fixed, thanks for finding this.
Contributor
|
LGTM |
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…tialised properly vitessio#10943 (vitessio#935) * Replicas should be able to heal if replication is not initialised properly (vitessio#10943) * feat: add code to also reset replication parameters in setReplicationSourceLocked when required Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix tests to reflect the change Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix vtworker tests Signed-off-by: Manan Gupta <manan@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the new GetSrvKeyspace vtgate API. Will require some work on import.
The tests are actually better for this than any other of our vtgate calls in python. We'll need to fix the rest.
@dumbunny @enisoc @guoliang100 @apmichaud