web/vtctld: Hook up actions in new interface.#885
Merged
enisoc merged 1 commit intovitessio:masterfrom Jul 16, 2015
Merged
Conversation
Contributor
|
LGTM |
enisoc
added a commit
that referenced
this pull request
Jul 16, 2015
web/vtctld: Hook up actions in new interface.
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 1, 2022
…) (vitessio#885) * Use introduced tablet manager RPCs in VTOrc (vitessio#10467) * feat: use the new RPC for resetting replication Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add code to get the full status and use it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove uptime from instance propoerties in VTOrc Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add end to end test for checking the output of ReadInstanceBufferable Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove a mysql query for server id, etc and use full status information instead Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: use primary status output instead of mysql query Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove semi-sync available, since it is unused Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: use semi sync enable from full status instead of mysql query Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: use semi sync statuses from full status instead of mysql query Signed-off-by: Manan Gupta <manan@planetscale.com> * test: check output of more fields in the test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove ReplicationCredentialsAvailable since it is unused Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: use executed, purged gtid set, server uuid, gtid mode and binlog row image from full status instead of mysql query Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add testing for replication status fields Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: check for nil values to prevent panics when some fields are empty Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: use replication status from full status instead of mysql query Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add license and shorten package name Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix test flakiness Signed-off-by: Manan Gupta <manan@planetscale.com> * feat:fix test to work with mysql 8.0 too Signed-off-by: Manan Gupta <manan@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alainjobart