Merged
Conversation
(defines CallerID and RPCError).
Member
|
LGTM |
Contributor
Author
|
I am merging this, but it is mostly unused, and can be fixed forward. |
alainjobart
added a commit
that referenced
this pull request
Jun 10, 2015
Contributor
|
LGTM |
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Jun 27, 2022
…sio#772) This was accidentally removed in vitessio#10512 but it shouldn't have been. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the new consolidated version of all services, defined as proto3. Please review, this will touch everybody's areas:
@guoliang100 vtrpc queryservice vtgateservice (Target, CallerID, RPCError)
@sougou everything, especially queryservice vtgateservice
@enisoc topo replication binlog tabletmanager
@yaoshengzhe queryservice and vtgateservice for SplitQuery
@aaijazi RPCError in vtrpc
I'm converting everything to match the spec (Call, CallRequest, CallResponse, CallerID, RPCError, ...).
Note we can now define enums in the protos, I'm doing that for tablet type for instance, or for the RPC error codes.
Next I will start using the newly defined structures and enums in the code, where they map 1-to-1 easily, to remove the go versions defined in go/vt/.../proto. So I'd like the proto version to be as solid as possible. Only once this is approved by everybody can I move forward.
Also, I'll start implementing the gRPC endpoints for some RPC calls in open source and google3, and the stubbyp3 endpoints in google3 (proto3 over stubby).