Added: api/keyspace/tablets/[shard]#4232
Merged
sougou merged 4 commits intovitessio:masterfrom Oct 17, 2018
Merged
Conversation
added 2 commits
September 12, 2018 12:05
Updating from upstream
Signed-off-by: Shlomi Noach <shlomi-noach@github.com>
Closed
Contributor
|
@shlomi-noach would it make more sense to have the the endpoints be |
Contributor
Author
|
@dkhenry sure, I'll modify the path. |
added 2 commits
October 15, 2018 11:23
Signed-off-by: Shlomi Noach <shlomi-noach@github.com>
Signed-off-by: Shlomi Noach <shlomi-noach@github.com>
Contributor
Author
|
Endpoint path has changed as per request, and is now:
This is deployed and runs well in production. |
sougou
approved these changes
Oct 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmission of #4207, having messed up commit signoff.
This PR adds an API endpoint to
vtctld:/api/ks_tables/my_keyspace/api/ks_tables/my_keyspace/-80EDIT: endpoint path has changed as per request, see comments below.
The API returns a list of all tablets for a given
keyspace, optionally further filtered byshard.The context for this PR is https://github.com/github/freno, and in particular github/freno#70: giving the
frenothrottling tool an easy way to determine the roster of MySQL servers (host & port) it needs to poll for replication lag.cc @github/database-infrastructure