Merged
Conversation
Signed-off-by: Greg Bird <greg.bird@joltup.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Aaron Young <young@squareup.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
… tests on string field table Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Shlomi Noach <shlomi-noach@github.com>
Signed-off-by: Shlomi Noach <shlomi-noach@github.com>
For a high QPS application, the sqlparser generates a ton of garbage. ``` 622GB 26.33% 60.87% 880.50GB 37.28% vitess.io/vitess/go/vt/sqlparser.yyParse 212.57GB 9.00% 69.87% 258.49GB 10.94% vitess.io/vitess/go/vt/sqlparser.(*yyParserImpl).Parse ``` Most of this, per the heap profile is allocations of new `yyParserImpl` objects for every call to `yyParse`. This diff uses `sync.Pool` to mitigate the total allocation overhead. Modifies sql.y to fix a place where we took a reference to a stack variable rather than making an intermediate copy. Resolves #4174 Signed-off-by: Daniel Tahara <tahara@dropbox.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
We already use such strategy for read buffers, so it makes sense to do the same for writes. Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Aaron Young <young@squareup.com>
This should be indicative for changing ephemeral packets allocation strategies Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
[go/mysql] use sync.Pool for write buffers
Flush binary logs while reparenting
…-type Handle bit types properly so that UPDATE and DELETE work as expected during replication
[Sqlparser] Pool the yyParserImpls
Fixing PID file creation and deletion
Allow the option of using null values in vindex fields
[go/mysql] add benchmark for random query sizes
update docs to use new proxy url in k8s example
Now when we get smaller than we want buffer from pool, we just put it back and allocate a new one. This might be quite inefficient. So, instead use multiple pools which always return buffers >= request size. Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…-type #4145 changes based on review
Just return whole query back as result Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
[go/mysql] make query benchmarks more even to reads and writes
[go/mysql] use tiered pool for buffers to avoid false hits
Just use sync.Pool always Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
[go/mysql] Avoid static buffer and use tiered pool in
Signed-off-by: Aaron Young <aaron.young@gmail.com>
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Allow updating fields to null
Kill vtctld commands that outlive the http request context
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Handling error from flush required me to pull it out of the wrapped function, and this ended up making it unnecessary. The flush is now called at the end of the block. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
If there are write errors while writing responses, then the handle function may return without flush getting called. This change calls flush on the defer to make sure we return the write buffer back to the pool. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
mysql: improve code structure for buffered vs unbuffered writes
rashiq
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Implement VDiff2 delete command Also add --verbose flag for VDiff output Signed-off-by: Matt Lord <mattalord@gmail.com> * Delete vdiff metadata associated with a deleted workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * Tweaks after self review Signed-off-by: Matt Lord <mattalord@gmail.com> * Self review #2 Signed-off-by: Matt Lord <mattalord@gmail.com> * Spelling is herd Signed-off-by: Matt Lord <mattalord@gmail.com> * Add test for vdiff data cleanup on workflow deletion Signed-off-by: Matt Lord <mattalord@gmail.com> * Caught mistake on self-review #3 Signed-off-by: Matt Lord <mattalord@gmail.com> * Add a couple more delete tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Clear out vdiff_log table as well on workflow deletion Signed-off-by: Matt Lord <mattalord@gmail.com>
rashiq
pushed a commit
that referenced
this pull request
Oct 26, 2022
* decouple olap tx timeout from oltp tx timeout
Since workload=olap bypasses the query timeouts
(--queryserver-config-query-timeout) and also row limits, the natural
assumption is that it also bypasses the transaction timeout.
This is not the case, e.g. for a tablet where the
--queryserver-config-transaction-timeout is 10.
This commit:
* Adds new CLI flag and YAML field to independently configure TX
timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout).
* Decouples TX kill interval from OLTP TX timeout via new CLI flag and
YAML field (--queryserver-config-transaction-killer-interval).
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #1
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #2 consolidate timeout logic in sc
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: remove unused tx killer flag
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: fix race cond
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #3 -txProps.timeout, +sc.expiryTime
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #4 -atomic.Value for expiryTime
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value)
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #5 -unused funcs, fix comments, set ticks interval once
Signed-off-by: Max Englander <max@planetscale.com>
* decouple ol{a,t}p tx timeouts: pr comments #5 +txkill tests
Signed-off-by: Max Englander <max@planetscale.com>
* revert fmt changes
Signed-off-by: Max Englander <max@planetscale.com>
* implement pr review suggestion
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
jspawar
pushed a commit
that referenced
this pull request
May 18, 2023
) * Cleanup tx_throttler.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Cleanup tx_throttler.go #2 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix throttlerFactoryFunc Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Undo if-cond consolidation Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Undo struct shuffling Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * prove that disabled config returns nil error Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Improve test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, to grab vitessio#4177