Change VitessInputFormat key type#199
Merged
yaoshengzhe merged 1 commit intovitessio:masterfrom Dec 10, 2014
yaoshengzhe:master
Merged
Change VitessInputFormat key type#199yaoshengzhe merged 1 commit intovitessio:masterfrom yaoshengzhe:master
yaoshengzhe merged 1 commit intovitessio:masterfrom
yaoshengzhe:master
Conversation
Contributor
|
Looks good. I would remove KeyspaceIdWritable entirely. |
Contributor
Author
|
KeyspaceIdWritable seems still useful for some utility classes, let's keep it for now. |
Make VitessInputFormat emit <NullWritable, RowWritable> instead of <KeyspaceIdWritable, RowWritable>
yaoshengzhe
added a commit
that referenced
this pull request
Dec 10, 2014
Change VitessInputFormat key type
vmg
pushed a commit
to vmg/vitess
that referenced
this pull request
Apr 8, 2021
This checks if a vtgate is currently filtering keyspaces before requesting the TopoServer. This is necessary because a TopoServer can't be accessed in those cases as the filtered Topo in those cases could make it unsafe to make writes since all reads would be returning a subset of the actual topo data. The only use of the requested topoServer that I found was in the DDL handling path and was introduced in vitessio#6547. This is deployed on dev but should get testing (endtoend or unit, unclear on best path atm) before going upstream.
deepthi
pushed a commit
that referenced
this pull request
Apr 22, 2021
This checks if a vtgate is currently filtering keyspaces before requesting the TopoServer. This is necessary because a TopoServer can't be accessed in those cases as the filtered Topo in those cases could make it unsafe to make writes since all reads would be returning a subset of the actual topo data. The only use of the requested topoServer that I found was in the DDL handling path and was introduced in #6547. This is deployed on dev but should get testing (endtoend or unit, unclear on best path atm) before going upstream. # Conflicts: # go/vt/vtgate/vcursor_impl.go Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
deepthi
pushed a commit
to planetscale/vitess
that referenced
this pull request
Apr 22, 2021
This checks if a vtgate is currently filtering keyspaces before requesting the TopoServer. This is necessary because a TopoServer can't be accessed in those cases as the filtered Topo in those cases could make it unsafe to make writes since all reads would be returning a subset of the actual topo data. The only use of the requested topoServer that I found was in the DDL handling path and was introduced in vitessio#6547. This is deployed on dev but should get testing (endtoend or unit, unclear on best path atm) before going upstream. # Conflicts: # go/vt/vtgate/vcursor_impl.go Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make VitessInputFormat emit <NullWritable, RowWritable> instead of
<KeyspaceIdWritable, RowWritable>