Skip to content

[release-23.0] evalengine: make JSON_EXTRACT work with non-static arguments (#19035)#19254

Merged
arthurschreiber merged 1 commit intorelease-23.0from
backport-19035-to-release-23.0
Feb 2, 2026
Merged

[release-23.0] evalengine: make JSON_EXTRACT work with non-static arguments (#19035)#19254
arthurschreiber merged 1 commit intorelease-23.0from
backport-19035-to-release-23.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Jan 30, 2026

Description

This is a backport of #19035

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@vitess-bot vitess-bot bot added the Type: Bug label Jan 30, 2026
@vitess-bot vitess-bot bot requested a review from dbussink as a code owner January 30, 2026 17:40
@vitess-bot vitess-bot bot added Backport This is a backport Component: Evalengine changes to the evaluation engine labels Jan 30, 2026
@vitess-bot vitess-bot bot requested a review from systay as a code owner January 30, 2026 17:40
@vitess-bot vitess-bot bot requested a review from arthurschreiber January 30, 2026 17:40
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 88.11881% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.72%. Comparing base (5321865) to head (920bf0b).
⚠️ Report is 10 commits behind head on release-23.0.

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/compiler_asm.go 78.94% 8 Missing ⚠️
go/vt/vtgate/evalengine/fn_json.go 86.20% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.0   #19254      +/-   ##
================================================
+ Coverage         69.70%   69.72%   +0.02%     
================================================
  Files              1606     1606              
  Lines            214599   214792     +193     
================================================
+ Hits             149590   149768     +178     
- Misses            65009    65024      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber arthurschreiber merged commit 7282f6a into release-23.0 Feb 2, 2026
113 of 119 checks passed
@arthurschreiber arthurschreiber deleted the backport-19035-to-release-23.0 branch February 2, 2026 11:24
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…rguments (vitessio#19035) (vitessio#19254)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…rguments (vitessio#19035) (vitessio#19254)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…rguments (vitessio#19035) (vitessio#19254)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…rguments (vitessio#19035) (vitessio#19254)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Evalengine changes to the evaluation engine Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant