Skip to content

VStream: Try new tablet on purged binlog error#18710

Merged
arthurschreiber merged 2 commits intovitessio:mainfrom
twthorn:vstream_try_new_tablet_on_purged_binlogs_error
Sep 30, 2025
Merged

VStream: Try new tablet on purged binlog error#18710
arthurschreiber merged 2 commits intovitessio:mainfrom
twthorn:vstream_try_new_tablet_on_purged_binlogs_error

Conversation

@twthorn
Copy link
Copy Markdown
Contributor

@twthorn twthorn commented Sep 30, 2025 •
edited by mattlord
Loading

Description

Before these changes, if we get a "purged binlogs" error we do not add the tablet to the ignore list. There could be other tablets with the binlog history, so we should add this tablet to the ignore list (similar to what we do for the GTID set mismatch error).

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Sep 30, 2025 •
edited by mattlord
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 30, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Sep 30, 2025
@mattlord mattlord added Type: Bug Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 30, 2025
@mattlord
Copy link
Copy Markdown
Member

mattlord commented Sep 30, 2025

@twthorn please see my comment here: #18696 (comment)

Let me know what you think. I'm happy to discuss it further here or in the Vitess Slack. Thank you for working on this! ❤️

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.50%. Comparing base (bc0a7c5) to head (5160d13).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #18710      +/-   ##
==========================================
- Coverage   67.51%   67.50%   -0.02%     
==========================================
  Files        1606     1606              
  Lines      263606   263612       +6     
==========================================
- Hits       177981   177948      -33     
- Misses      85625    85664      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@twthorn
VStream: Try new tablet on purged binlog error
ad54fd5 
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
@twthorn
Match binary log purged case on sql error codes
5160d13 
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
@twthorn twthorn force-pushed the vstream_try_new_tablet_on_purged_binlogs_error branch from e854d32 to 5160d13 Compare September 30, 2025 22:26
@twthorn
Copy link
Copy Markdown
Contributor Author

twthorn commented Sep 30, 2025

Force pushed to add sign off.

mattlord
mattlord approved these changes Sep 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. 🙂 Thanks, @twthorn!

@arthurschreiber arthurschreiber enabled auto-merge (squash) September 30, 2025 23:20
@arthurschreiber arthurschreiber merged commit ed3d929 into vitessio:main Sep 30, 2025
103 of 108 checks passed
twthorn added a commit to slackhq/vitess that referenced this pull request Oct 17, 2025
@twthorn
VStream: Try new tablet on purged binlog error (vitessio#18710)
32b68fb 
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
@twthorn twthorn mentioned this pull request Oct 17, 2025
Merged
5 tasks
tanjinx pushed a commit to slackhq/vitess that referenced this pull request Oct 17, 2025
@twthorn
VStream: Try new tablet on purged binlog error (vitessio#18710) (#715)
b37023b 
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
twthorn added a commit to slackhq/vitess that referenced this pull request Oct 21, 2025
@twthorn
VStream: Try new tablet on purged binlog error (vitessio#18710)
fad7094 
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
@twthorn twthorn mentioned this pull request Oct 21, 2025
Merged
5 tasks
tanjinx pushed a commit to slackhq/vitess that referenced this pull request Oct 23, 2025
@twthorn @tanjinx
VStream: Try new tablet on purged binlog error (vitessio#18710) (#715)
18eabba 
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
tanjinx added a commit to slackhq/vitess that referenced this pull request Oct 24, 2025
@twthorn @beingnoble03 @tanjinx
Tthornton slack 22.0 backports (#717)
a8953ef 
* VStream: Add flag to support copying only specific tables (vitessio#18184)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Add a flag to vstream to exclude keyspace from table name (vitessio#18274)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix flakey vstream metrics test (vitessio#18287)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Add support for sending grpc server backend metrics via ORCA (vitessio#18282)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* VStream: Try new tablet on purged binlog error (vitessio#18710)

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>

* Run go mod tidy

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Run go fmt

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Regenerate proto files

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix sorting of --grpc-enable-orca-metrics flag

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix ordering of -grpc-enable-orca-metrics in vtcombo.txt

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

---------

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com>
Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
tanjinx added a commit to slackhq/vitess that referenced this pull request Nov 10, 2025
@twthorn @beingnoble03 @tanjinx
Tthornton slack 22.0 backports (#717)
24cad80 
* VStream: Add flag to support copying only specific tables (vitessio#18184)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Add a flag to vstream to exclude keyspace from table name (vitessio#18274)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix flakey vstream metrics test (vitessio#18287)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Add support for sending grpc server backend metrics via ORCA (vitessio#18282)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* VStream: Try new tablet on purged binlog error (vitessio#18710)

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>

* Run go mod tidy

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Run go fmt

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Regenerate proto files

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix sorting of --grpc-enable-orca-metrics flag

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix ordering of -grpc-enable-orca-metrics in vtcombo.txt

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

---------

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com>
Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
sbaker617 pushed a commit to slackhq/vitess that referenced this pull request Feb 5, 2026
@twthorn @beingnoble03
@tanjinx @sbaker617
Tthornton slack 22.0 backports (#717)
72a84e2 
* VStream: Add flag to support copying only specific tables (vitessio#18184)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Add a flag to vstream to exclude keyspace from table name (vitessio#18274)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix flakey vstream metrics test (vitessio#18287)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Add support for sending grpc server backend metrics via ORCA (vitessio#18282)

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* VStream: Try new tablet on purged binlog error (vitessio#18710)

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>

* Run go mod tidy

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Run go fmt

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Regenerate proto files

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix sorting of --grpc-enable-orca-metrics flag

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

* Fix ordering of -grpc-enable-orca-metrics in vtcombo.txt

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>

---------

Signed-off-by: Thomas Thornton <tthornton@salesforce.com>
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com>
Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
corbantek pushed a commit to HubSpot/vitess that referenced this pull request Mar 4, 2026
@twthorn @corbantek
HubSpot cherry-pick from v23 -- VStream: Try new tablet on purged bin…
7542aaa 
…log error (vitessio#18710)

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@mattlord mattlord mattlord approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees

No one assigned

Labels

Component: VReplication Type: Bug

Projects

None yet

Milestone

v23.0.0

Development

Successfully merging this pull request may close these issues.

Bug Report: Handle 'the source purged required binary logs' during vstream subscription

3 participants

@twthorn @mattlord @arthurschreiber