Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

Codecov Report

Attention: Patch coverage is 40.82840% with 100 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (056afc9) to head (c77ab79).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main   #16857      +/-   ##
==========================================
- Coverage   69.45%   69.41%   -0.05%     
==========================================
  Files        1570     1570              
  Lines      203631   203798     +167     
==========================================
+ Hits       141441   141474      +33     
- Misses      62190    62324     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I assume this change would need some website docs that I'm happy to add. Any suggestions "where" this should go is appreciated!

👋 I've tested this on our infrastructure and things are looking good so far (after fixing one issue):

tvaillancourt@REDACTED:~$ vtctldclient $FLAGS GetTablet us_east_1b-0170348168 | jq .tags
{
  "hello": "world"
}
tvaillancourt@REDACTED:~$ vtctldclient $FLAGS ChangeTabletTags us_east_1b-0170348168 test=123
- [hello: "world"]
+ [hello: "world" test: "123"]
tvaillancourt@REDACTED:~$ vtctldclient $FLAGS GetTablet us_east_1b-0170348168 | jq .tags
{
  "hello": "world",
  "test": "123"
}

And --replace mode:

tvaillancourt@REDACTED:~$ vtctldclient $FLAGS ChangeTabletTags --replace us_east_1b-0170348168 replace=true 
- [hello: "world" test: "123"]
+ [replace: "true"]
tvaillancourt@REDACTED:~$ vtctldclient $FLAGS GetTablet us_east_1b-0170348168 | jq .tags
{
  "replace": "true"
}

And the stats:

tvaillancourt@REDACTED:~$ curl -s localhost:15000/metrics | grep tablet_tags
# HELP vttablet_tablet_tags Tablet tags key/values
# TYPE vttablet_tablet_tags gauge
vttablet_tablet_tags{key="replace",value="true"} 1

And the vttablet log:

I1002 06:06:49.280457 1915886 tm_state.go:243] Changing Tablet Tags: map[replace:true] for cell:"us_east_1b" uid:170348168