[vtadmin/tests] Serialize Schema test cases to avoid cache backfill races#10538
Merged
ajm188 merged 1 commit intovitessio:mainfrom Jun 17, 2022
Merged
Conversation
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
GuptaManan100
approved these changes
Jun 17, 2022
ajm188
pushed a commit
to planetscale/vitess
that referenced
this pull request
Jun 17, 2022
…0538) Signed-off-by: Andrew Mason <andrew@planetscale.com>
3 tasks
ajm188
pushed a commit
that referenced
this pull request
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What it says on the tin.
Before,
go test -race -run '.*Schema.*' -count=10 ./go/vt/vtadmin/failed reliably locally, and passes reliably (N=3, to be fair) now.Related Issue(s)
Checklist
Deployment Notes