Skip to content

[vtadmin/tests] Serialize Schema test cases to avoid cache backfill races#10538

Merged
ajm188 merged 1 commit intovitessio:mainfrom
planetscale:andrew/fix-vtadmin-authz-races
Jun 17, 2022
Merged

[vtadmin/tests] Serialize Schema test cases to avoid cache backfill races#10538
ajm188 merged 1 commit intovitessio:mainfrom
planetscale:andrew/fix-vtadmin-authz-races

Conversation

@ajm188
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 commented Jun 17, 2022

Description

What it says on the tin.

Before, go test -race -run '.*Schema.*' -count=10 ./go/vt/vtadmin/ failed reliably locally, and passes reliably (N=3, to be fair) now.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@github-actions
Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@ajm188 ajm188 merged commit 00e29d6 into vitessio:main Jun 17, 2022
@ajm188 ajm188 deleted the andrew/fix-vtadmin-authz-races branch June 17, 2022 14:23
ajm188 pushed a commit to planetscale/vitess that referenced this pull request Jun 17, 2022
…0538)

Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188 pushed a commit that referenced this pull request Jun 17, 2022
…10540)

Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants