Skip to content

[vtadmin] Document known issue with node versions 17+#10483

Merged
ajm188 merged 1 commit intovitessio:mainfrom
planetscale:andrew/vtadmin/node-ssl-doc
Jun 9, 2022
Merged

[vtadmin] Document known issue with node versions 17+#10483
ajm188 merged 1 commit intovitessio:mainfrom
planetscale:andrew/vtadmin/node-ssl-doc

Conversation

@ajm188
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 commented Jun 9, 2022

Description

This fixes a build issue of the form:

Creating an optimized production build...
Failed to compile.

Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required -- N/A
  • Documentation was added or is not required

Deployment Notes

Document known issue with node versions 17+
81f834b 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 added this to the v14.0 milestone Jun 9, 2022
@ajm188 ajm188 requested a review from mattlord June 9, 2022 15:11
@ajm188 ajm188 requested review from doeg and notfelineit as code owners June 9, 2022 15:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 9, 2022 •
edited by mattlord
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@ajm188 ajm188 merged commit f928f8a into vitessio:main Jun 9, 2022
@ajm188 ajm188 deleted the andrew/vtadmin/node-ssl-doc branch June 9, 2022 16:29
ajm188 pushed a commit to planetscale/vitess that referenced this pull request Jun 9, 2022
Document known issue with node versions 17+ (vitessio#10483)
0440251 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 mentioned this pull request Jun 9, 2022
Merged
3 tasks
deepthi pushed a commit that referenced this pull request Jun 17, 2022
Document known issue with node versions 17+ (#10483) (#10484)
a0977ad 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@doeg doeg Awaiting requested review from doeg

@notfelineit notfelineit Awaiting requested review from notfelineit

Assignees

No one assigned

Labels

Component: VTAdmin VTadmin interface Type: Documentation

Projects

None yet

Milestone

v14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ajm188 @mattlord