fix: aggregation empty row on join with grouping and aggregations#10480
Merged
harshit-gangal merged 1 commit intovitessio:mainfrom Jun 9, 2022
Merged
fix: aggregation empty row on join with grouping and aggregations#10480harshit-gangal merged 1 commit intovitessio:mainfrom
harshit-gangal merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
systay
approved these changes
Jun 9, 2022
frouioui
approved these changes
Jun 9, 2022
harshit-gangal
added a commit
to planetscale/vitess
that referenced
this pull request
Jun 21, 2022
…tessio#10480) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an aggregation-grouping bug in gen4 that does non-scalar aggregates on a top of a join.
This happens when the left side of the join has data and no data is present on the right hand side.
If the right hand side of the join only contains an aggregation then even though the table has no data it will return count(*) as
0and that will get mapped to the join output.To avoid such scenario the change adds a grouping condition on the right hand side using literal 1 so that the rows from right hand side is only returned when the join condition matches.
Related Issue(s)
Checklist
Deployment Notes