Skip to content

[vtadmin] authz tests - tablet actions#10457

Merged
ajm188 merged 11 commits intovitessio:mainfrom
planetscale:andrew/vtadmin/authz-tests-tablet-actions
Jun 8, 2022
Merged

[vtadmin] authz tests - tablet actions#10457
ajm188 merged 11 commits intovitessio:mainfrom
planetscale:andrew/vtadmin/authz-tests-tablet-actions

Conversation

@ajm188
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 commented Jun 7, 2022

Description

This adds authz tests for every. single. tablet. action. 🎉

Related Issue(s)

#10397

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@ajm188 ajm188 added this to the v14.0 milestone Jun 7, 2022
@ajm188 ajm188 requested a review from deepthi June 7, 2022 13:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Andrew Mason added 11 commits June 8, 2022 14:36
Add PingTablet to mock vtctld
09fff97 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for PingTablet
5ccf25c 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for RefreshState
5a496b5 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for RefreshTabletReplicationSource
ed1d3bc 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add RunHealthCheck to mock vtctld
f0fb65e 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for RunHealthCheck
59e9804 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for SetReadOnly
2003bb7 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for SetReadWrite
d63ce48 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for StartReplication
9b7384e 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for StopReplication
285b619 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Add authz tests for TabletExternallyPromoted
27094af 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 force-pushed the andrew/vtadmin/authz-tests-tablet-actions branch from 0dd952e to 27094af Compare June 8, 2022 18:36
@ajm188 ajm188 merged commit 8316dd5 into vitessio:main Jun 8, 2022
@ajm188 ajm188 deleted the andrew/vtadmin/authz-tests-tablet-actions branch June 8, 2022 21:19
ajm188 pushed a commit to planetscale/vitess that referenced this pull request Jun 8, 2022
[vtadmin] authz tests - tablet actions (vitessio#10457)
564f8da 
* Add PingTablet to mock vtctld

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for PingTablet

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for RefreshState

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for RefreshTabletReplicationSource

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add RunHealthCheck to mock vtctld

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for RunHealthCheck

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for SetReadOnly

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for SetReadWrite

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for StartReplication

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for StopReplication

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for TabletExternallyPromoted

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 mentioned this pull request Jun 8, 2022
Merged
3 tasks
ajm188 pushed a commit that referenced this pull request Jun 9, 2022
[vtadmin] authz tests - tablet actions (#10457) (#10477)
f4bd7b1 
* Add PingTablet to mock vtctld

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for PingTablet

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for RefreshState

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for RefreshTabletReplicationSource

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add RunHealthCheck to mock vtctld

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for RunHealthCheck

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for SetReadOnly

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for SetReadWrite

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for StartReplication

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for StopReplication

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Add authz tests for TabletExternallyPromoted

Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doeg doeg Awaiting requested review from doeg

@notfelineit notfelineit Awaiting requested review from notfelineit

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: VTAdmin VTadmin interface Type: Testing

Projects

None yet

Milestone

v14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ajm188 @deepthi