fix: module graph ensureEntryFromUrl based on id#9759
Merged
Conversation
patak-cat
approved these changes
Aug 19, 2022
Member
patak-cat
left a comment
There was a problem hiding this comment.
Interesting that this wasn't causing more issues. Let's merge it now so we can test it during the 3.1 beta. I'll run a vite-ecosystem-ci against this branch before just in case
1 task
Member
|
Full ecosystem CI green for this PR. There was a glitch in Rakkas, but it is now solved. |
9 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we check for a module existence via url in
ensureEntryForUrl, but a url could map to the same resolved id that already exists inidToModulesMap(e.g. via a different url that also resolves to the same id).This can currently happen for two URLs like:
This PR changes to check the resolved id instead, and update the url to use the existing id & module if possible.
Additional context
Ref withastro/astro#4378
Feels related to #9730 and #7845
Something similar has been happening in SvelteKit too
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).