fix: get two different copies of the same module#7845
Closed
Bigfish8 wants to merge 1 commit intovitejs:mainfrom
Closed
fix: get two different copies of the same module#7845Bigfish8 wants to merge 1 commit intovitejs:mainfrom
Bigfish8 wants to merge 1 commit intovitejs:mainfrom
Conversation
Contributor
|
I'm afraid that the issue is still not totally solved. I could still get different copies in my project (in a more complex scenario) I'll try to provide another repro later 🤔 |
Contributor
|
@Bigfish8 Hi, I tested your fix on Vite 3 and could still repro the issue on another case - importing from a sub directory in a bare imports. I've updated the original reproduce repo. |
Contributor
|
Alright, I got the point. I think we should cache the final resolved |
9 tasks
9 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7621, #2503
Additional context
Because of the hash query, bare import and fs import from
node_modulesfor same module will get the different result.Use Map to dedupe.
The case in #7621 and #2503 works well in the PR.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).