fix: added support legacy browsers in preload code#9001
Closed
NikolayMakhonin wants to merge 1 commit intovitejs:mainfrom
Closed
fix: added support legacy browsers in preload code#9001NikolayMakhonin wants to merge 1 commit intovitejs:mainfrom
NikolayMakhonin wants to merge 1 commit intovitejs:mainfrom
Conversation
✅ Deploy Preview for vite-docs-main canceled.
|
NikolayMakhonin
added a commit
to NikolayMakhonin/svelte-kit-template-old
that referenced
this pull request
Jul 9, 2022
7 tasks
Author
|
Solved in this issue. This pull request will be worse than the solution described there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced modern js features in preload code with their legacy equivalents for support legacy browsers.
Additional context
The initial purpose is to add support legacy browsers to the @svelte/kit. You can see my template project for this:
https://github.com/NikolayMakhonin/svelte-kit-template
I have tested these changes for svelte/kit in Chromium 39 and 44. It worked. But I'm not sure if the same problem won't happen again in the future for other frameworks.
The most frequent modern js features, that I had replace in defferent projects for support legcy browsers:
varinsteadlet/conststartsWith/endsWithArray.fromWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).