fix: preserve extension of css assets in the manifest#8768
Merged
patak-cat merged 5 commits intovitejs:mainfrom Jun 27, 2022
Merged
fix: preserve extension of css assets in the manifest#8768patak-cat merged 5 commits intovitejs:mainfrom
patak-cat merged 5 commits intovitejs:mainfrom
Conversation
✅ Deploy Preview for vite-docs-main canceled.
|
Contributor
Author
|
@jessarcher @innocenzi Would you check if this commit is desirable or not? Not sure how the Laravel plugins are using |
Contributor
|
If I understood correctly what pure CSS chunks are, LGTM 👍 I use |
Contributor
|
@ElMassimo This looks great, thanks! I've tested it out with both The official Laravel plugin isn't actually using |
patak-cat
approved these changes
Jun 27, 2022
Member
|
Thanks for the feature review and quick fix @ElMassimo! |
ElMassimo
added a commit
to ElMassimo/vite_ruby
that referenced
this pull request
Jul 1, 2022
Since vitejs/vite#8768 Vite will now add style assets to the manifest preserving the original extension.
9 tasks
This was referenced Jan 25, 2023
Closed
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8764 by preserving the original extension for CSS asset entry names in the manifest.
It also preserves
isEntryinformation for CSS asset chunks, which is useful for backend integrations.Additional context
#6649 added assets to the manifest, but the entries are invalid for Sass/Less/Stylus stylesheets, as it's erasing the original extension from the manifest entry names and src.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).