Skip to content

feat: supports cts and mts config#8729

Merged
patak-cat merged 5 commits intovitejs:mainfrom
sxzz:feat/config-ext
Jun 24, 2022
Merged

feat: supports cts and mts config#8729
patak-cat merged 5 commits intovitejs:mainfrom
sxzz:feat/config-ext

Conversation

@sxzz
Copy link
Member

@sxzz sxzz commented Jun 22, 2022 •
edited
Loading

Description

Support mts / cts / cjs config files

closes #5201

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jun 22, 2022 •
edited
Loading

✅ Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 438a9b8
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b5827b4001a50009f584cc
😎 Deploy Preview https://deploy-preview-8729--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sxzz sxzz changed the title feat: supports cjs and esm config feat: supports cts and mts config Jun 22, 2022
@sxzz sxzz marked this pull request as ready for review June 22, 2022 17:34
@sxzz sxzz mentioned this pull request Jun 22, 2022
Closed
4 tasks
@sxzz

This comment was marked as outdated.

Sign in to view
@sapphi-red sapphi-red added enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority) labels Jun 23, 2022
poyoho
poyoho reviewed Jun 24, 2022
View reviewed changes
poyoho
poyoho previously approved these changes Jun 24, 2022
View reviewed changes
sapphi-red
sapphi-red reviewed Jun 24, 2022
View reviewed changes
poyoho
poyoho previously approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@poyoho poyoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

sapphi-red
sapphi-red reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this filter needs to be /\.[mc]?[jt]s$/ now.

vite/packages/vite/src/node/config.ts

Line 959 in 9d16253

build.onLoad({ filter: /\.[jt]s$/ }, async (args) => {

For example, this code does not work.

// vite.config.mts
import { u } from './foo.mjs'
console.log(u) // expected: 'file://path/to/foo.mjs', actual: `ReferenceError: __vite_injected_original_import_meta_url is not defined`
// foo.mjs
export const u = import.meta.url

@sxzz
Copy link
Member Author

sxzz commented Jun 24, 2022

@sapphi-red
Thanks for reminding. Just fixed!

sapphi-red
sapphi-red approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@patak-cat patak-cat merged commit c2b09db into vitejs:main Jun 24, 2022
@sxzz sxzz deleted the feat/config-ext branch June 24, 2022 15:41
@sxzz sxzz mentioned this pull request Jun 24, 2022
Merged
@sxzz
Copy link
Member Author

sxzz commented Jun 24, 2022

Can I backport this feature to 2.x branch?

@sxzz sxzz mentioned this pull request Jun 24, 2022
Closed
9 tasks
@bluwy bluwy mentioned this pull request Jun 26, 2022
Closed
4 tasks
@ota-meshi ota-meshi mentioned this pull request Jul 7, 2022
Merged
haoqunjiang added a commit to haoqunjiang/cypress that referenced this pull request Jul 14, 2022
@haoqunjiang
feat: support vite.config.mts and vite.config.cts
c5f1e9e 
It's added in Vite 3.0:
vitejs/vite#8729
@haoqunjiang haoqunjiang mentioned this pull request Jul 14, 2022
Merged
astone123 pushed a commit to cypress-io/cypress that referenced this pull request Jul 15, 2022
@haoqunjiang
feat: support vite.config.mts and vite.config.cts (#22782)
8678053 
It's added in Vite 3.0:
vitejs/vite#8729
@andrewbranch
Copy link

andrewbranch commented Jul 15, 2022

I don’t think this fully addresses #5201—this only supports .cts and .mts config files, but .cts and .mts source files are not recognized as TypeScript. Is that intended to be supported by Vite?

Unexpected token (Note that you need plugins to import files that are not JavaScript)
file: /Users/andrew/Developer/microsoft/module-resolvers/code/resolvers/vite/main.mts:1:7
1: const x: string = 'hello';
          ^
error during build:
Error: Unexpected token (Note that you need plugins to import files that are not JavaScript)

@bluwy
Copy link
Member

bluwy commented Jul 16, 2022

Yeah looks like this covers config files only. We should support source files too. Re-opening the issue.

@CHOYSEN CHOYSEN mentioned this pull request Jul 16, 2022
Merged
@sxzz sxzz mentioned this pull request Jul 21, 2022
Merged
9 tasks
@pantajoe pantajoe mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

+1 more reviewer

@poyoho poyoho poyoho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support mts and cts file

6 participants

@sxzz @andrewbranch @bluwy @poyoho @sapphi-red @patak-cat