fix: remove empty chunk css imports when using esnext#8345
Merged
patak-cat merged 2 commits intovitejs:mainfrom Jun 1, 2022
Merged
fix: remove empty chunk css imports when using esnext#8345patak-cat merged 2 commits intovitejs:mainfrom
patak-cat merged 2 commits intovitejs:mainfrom
Conversation
sapphi-red
reviewed
May 27, 2022
Co-authored-by: 翠 / green <green@sapphi.red>
patak-cat
pushed a commit
that referenced
this pull request
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8330
esnexta single quote rather than double quote is used. Fixing the regex causes it to remove the empty chunk import statement correctly.Additional context
This fixes a bug in Astro and Sveltekit (see sveltejs/kit#5052)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).