Tests are fixed. Seems like CI is flaky though

Tests are fixed. Seems like CI is flaky though

It is killing us, there is a node seg fault we are hitting constantly in v16

For anyone else who stumbles over this backwards-incompatible change in Vite 3.0: to get back env var replacements in lib builds, it is now necessary to manually add the relevant definitions to the Vite config. For example:

export default defineConfig({
  define: {
    "process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV),
  },
  ...
}

This will allow the resulting libraries to be used directly in the browser, without needing an additional build step.

Thanks for the tip @latk. I think this is worth a mention in the docs, since specifically mentions building a browser-oriented library. I'll make a PR for it.

@bluwy bluwy, I have a question, why skip the library build pattern case?

I am using react to build a library for the browser. React used process.env.NODE _ENV, and I found that you skipped the library mode when dealing with process polyfill. Is there any special reason for this?

Of course @latk 's method can solve my problem, I'm just curious.

@gwsbhqt Do you mean the process.env. polyfill being skipped specifically? It was so that nodejs libraries built with library mode can access process.env.* too, otherwise there isn't a way around it.

Hi @bluwy The behavior of code in define.ts when handling import.meta.env replacement in lib mode does not match the comments here https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/define.ts#L40

Shall we introduce a config flag replaceImportMetaEnv to the https://vitejs.dev/config/build-options.html config section and let user decide whether to replace or preserve?

Hmm that comment should be removed. It's likely I was testing things out and copy-pasted wrongly. The reason is that import.meta.env is a Vite specific feature, and we don't want libraries that work in Vite only. If you'd like, you can send a PR to remove that line.