fix: use strip-literal to strip string lterals#8054
Merged
Conversation
poyoho
previously approved these changes
May 7, 2022
poyoho
approved these changes
May 7, 2022
7 tasks
Shinigami92
approved these changes
May 7, 2022
antfu
added a commit
that referenced
this pull request
May 8, 2022
This was referenced Aug 23, 2022
6 tasks
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continues #7650
Using regex is impossible to handle this correctly. For example
While #7650 introduced a lexer for string templates, it does not cover well with mixing quotes.
I made https://github.com/antfu/strip-literal using acron's tokenizer to handle this correctly with the minimal overhead as possible. This also unblockers #7537
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).