feat: add ignore option to import.meta.glob#7482
Closed
brillout wants to merge 1 commit intovitejs:mainfrom
Closed
feat: add ignore option to import.meta.glob#7482brillout wants to merge 1 commit intovitejs:mainfrom
ignore option to import.meta.glob#7482brillout wants to merge 1 commit intovitejs:mainfrom
Conversation
9 tasks
Contributor
Author
|
I'm closing this PR in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows the user to define the
ignoreoption offast-glob:I removed @frandiox's changes:
Because this PR makes it obsolete. AFAICT only Hydrogen is using that functionality, thus I'm not worried about the breaking change. (I don't see why a Vite end-user would want to use a gob import to search inside
node_modules/.)I will additionally ping Fran on Discord about this.
Additional context
Follow up of #7436 and more specifically #7436 (comment).
Playground confirming that this PR works as intended: https://github.com/brillout/fast-glob-playground.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).