Interesting optimization. Did you perform some profiling? It would be great to have some numbers for real apps.

One issue is that this is potentially a breaking change in case a pattern will look into node_modules/package/node_modules, no? Should we detect this case and bailout? Maybe it isn't needed, I don't think nobody is using it in this way.

Added to discuss with the team.

The number of files in node_modules is much higher than the number of files in user land.

For example, the demo vps framework https://github.com/brillout/vite-plugin-ssr/tree/0.4.0/examples/framework. The framework/node_modules/ has 3102 files while framework/ without node_modules/ has only 15 files. So that's 200x less files for fast-glob to go through. For Hydrogen and future vps frameworks, we can expect this to be much more than 200x.

This means fast-glob will be much faster if we skip node_modules.

One issue is that this is potentially a breaking change in case a pattern will look into node_modules/package/node_modules, no? Should we detect this case and bailout? Maybe it isn't needed, I don't think nobody is using it in this way.

Yes, this PR makes import.meta.glob('node_modules/framework/**/*.page.js') ignore node_modules/framework/node_modules/some-library/pages/some.page.js. I also don't think anyone uses it: I don't see a use case for it, and Fran's PR is quite recent.

Added to discuss with the team.

As always, I can join the discussion as a guest, if there is interest. (I think, in general, inviting guests that the Vite team trusts to join team meetings for specific PRs could make sense.)

We talked about the PR today @brillout.

Since we now have added { as: 'raw' } to import.meta.glob, we think that it is better to avoid adding a new caveat. We can directly add an option to let the user ignore certain patterns:

import.meta.glob('node_modules/framework/**/*.page.js', { 
  ignore: 'node_modules/framework/**/node_modules/**' 
})

We didn't discuss this, but given that we support fast glob arrays in options like optimizeDeps.entries where we can pass ignored patterns using !. We could also support this as:

import.meta.glob([
  'node_modules/framework/**/*.page.js',
  '!node_modules/framework/**/node_modules' 
])

I don't know if we should support both, so we probably need to keep iterating. But I think we will end up with one of these two options.

Makes sense, I like it, and PR is done: #7482.

Closing this in favor of the new PR.