Skip to content

fix: revert #7052, hmr style tag no support in html#7136

Merged
patak-cat merged 1 commit intomainfrom
fix/revert-7052
Mar 1, 2022
Merged

fix: revert #7052, hmr style tag no support in html#7136
patak-cat merged 1 commit intomainfrom
fix/revert-7052

Conversation

@patak-cat
Copy link
Copy Markdown
Member

Fix #7124

Description

See #7124, @poyoho is working on this PR to re-merge it in 2.9. The issue may be on @IanVS's vite storybook builder side, but it is safer to introduce this change in a minor.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-cat patak-cat added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Mar 1, 2022
@patak-cat patak-cat merged commit 5c116ec into main Mar 1, 2022
@patak-cat patak-cat deleted the fix/revert-7052 branch March 1, 2022 19:45
sinoon pushed a commit to sinoon/vite that referenced this pull request Mar 2, 2022
poyoho added a commit to poyoho/vite that referenced this pull request Mar 11, 2022
@usercao
Copy link
Copy Markdown

usercao commented Apr 18, 2022

@patak-dev This problem reappears in version 2.9.5.

@poyoho
Copy link
Copy Markdown
Member

poyoho commented Apr 18, 2022

can you show this issues link ?

@usercao
Copy link
Copy Markdown

usercao commented Apr 18, 2022

can you show this issues link ?

#6032 #7124 Same question.

@poyoho
Copy link
Copy Markdown
Member

poyoho commented Apr 18, 2022

but there were closed, it only affects server mode. Do you ask for this #7786?

@usercao
Copy link
Copy Markdown

usercao commented Apr 18, 2022

I'm not sure, but as long as the <style></style> is added to the entry page index.html, this problem will recur.Error reporting is the same as 6032.

@patak-cat
Copy link
Copy Markdown
Member Author

@usercao please open a new issue with a minimal reprduction. Thanks!

@usercao usercao mentioned this pull request Apr 29, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.8.5] Invalid script being added to html

3 participants