test: Add failing tests for async css modules#6044
Closed
IanVS wants to merge 2 commits intovitejs:mainfrom
Closed
test: Add failing tests for async css modules#6044IanVS wants to merge 2 commits intovitejs:mainfrom
IanVS wants to merge 2 commits intovitejs:mainfrom
Conversation
Contributor
Author
|
I think @patak-dev's post sheds some light on what might be going on here: https://patak.dev/vite/build.html#_14-vite-css-post. Specifically, this part:
It seems like what is needed is a more robust tree-walking which does not simply create a .css file for each dynamically imported asset, but rather builds up a list of files that need to be created, and then actually inject them in the correct order. So, if we have Currently the import order is: But in reality what we need is: |
9 tasks
65817ee to
223148d
Compare
poyoho
added a commit
to poyoho/vite
that referenced
this pull request
Jan 6, 2022
Contributor
Author
|
The latest work on this is being done in #9278. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a failing test for #3924, to hopefully help someone who knows more than I do actually fix the bug.
Additional context
If someone can point me in the right direction I can take a crack at fixing this.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).