refactor!: plugin hooks ssr param to object#5253
Merged
Conversation
patak-cat
commented
Oct 11, 2021
patak-cat
commented
Oct 11, 2021
patak-cat
commented
Oct 11, 2021
Contributor
|
LGTM (Superficial review. Neat comprehensive docs update 👌.), and |
brillout
previously approved these changes
Oct 11, 2021
Shinigami92
previously approved these changes
Oct 12, 2021
Member
Shinigami92
left a comment
There was a problem hiding this comment.
Do we want to release this with 2.7, or before?
You could add this PR to the milestone dependant on the answer 🙂
Member
Author
|
I didnt add it yet because I dont know if we are targetting 2.7 or 2.8. But given the way the ecosystem reacted, it is probably going to be in the next minor |
4 tasks
Shinigami92
approved these changes
Oct 27, 2021
sfriedel
added a commit
to nubolab-ffwd/svelte-fluent
that referenced
this pull request
Dec 13, 2021
Adds backwards compatible handling of the plugin API changes from Vite 2.7 (vitejs/vite#5253)
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Feb 12, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See discussion at #5109 (comment).
This PR modifies the way Vite informs
ssrmode to plugin hooks from a positional param to a prop in theoptionsobject ofresolveId,transformandload. This was already discussed by the team and the plugin authors.What is the purpose of this pull request?