Skip to content

docs: clarify that server.hmr.server works with HTTP too#5163

Merged
patak-cat merged 1 commit intovitejs:mainfrom
fwouts:patch-2
Oct 1, 2021
Merged

docs: clarify that server.hmr.server works with HTTP too#5163
patak-cat merged 1 commit intovitejs:mainfrom
fwouts:patch-2

Conversation

@fwouts
Copy link
Contributor

@fwouts fwouts commented Oct 1, 2021

Description

This clarifies that server.hmr.server can be useful even when you don't use HTTPS :)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Oct 1, 2021
@patak-cat patak-cat closed this Oct 1, 2021
@patak-cat
Copy link
Member

🤦🏼‍♂️ wrong button, a confirmation from GitHub would be nice here

@patak-cat patak-cat reopened this Oct 1, 2021
@patak-cat patak-cat merged commit 63c7a88 into vitejs:main Oct 1, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@bluwy bluwy mentioned this pull request Mar 13, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants