feat(html): Inline entry chunk into html when possible#4555
Merged
patak-cat merged 3 commits intovitejs:mainfrom Sep 13, 2021
andylizi:html-inline-entry
Merged
feat(html): Inline entry chunk into html when possible#4555patak-cat merged 3 commits intovitejs:mainfrom andylizi:html-inline-entry
patak-cat merged 3 commits intovitejs:mainfrom
andylizi:html-inline-entry
Conversation
4 tasks
Member
|
On the first look, it's LGTM. |
patak-cat
approved these changes
Aug 13, 2021
Member
patak-cat
left a comment
There was a problem hiding this comment.
We discussed this feat with the team today and it looks good, and it is great that it also gives Vite Zero JS support. Thanks for this PR @andylizi, I think that @DylanPiercey and the marko team would be very happy to see this merged.
Shinigami92
approved these changes
Aug 13, 2021
DylanPiercey
approved these changes
Aug 13, 2021
4 tasks
Member
|
Thanks for implementing this feature @andylizi, we have merged this PR in preparations for vite 2.6-beta |
4 tasks
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
9 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the solution described in #4554. Please see over there for details.
Additional context
About possible breakage: I've been doing some testing recently, looking through the plugin list in awesome-vite and such, and I haven't found any plugin that would be affected by this change. As for existing projects, I think most of them probably won't depend on the old behaviour.
Fixes #4554, fixes #3127, closes #3129.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).