chore: KiB instead of kb unit by Mesteery · Pull Request #4493 · vitejs/vite

Mesteery · 2021-08-03T16:35:19Z

kb is wrong as a unit, because they are not kilobytes, but kibibytes.

Read the Contributing Guidelines.
Read the Pull Request Guidelines and follow the Commit Convention.
Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

`kb` is wrong as a unit, because they are not kilobytes, but kibibytes.

feat(reporter): KiB instead of kb unit

afb552a

`kb` is wrong as a unit, because they are not kilobytes, but kibibytes.

Shinigami92 approved these changes Aug 3, 2021

View reviewed changes

Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Aug 3, 2021

antfu approved these changes Aug 5, 2021

View reviewed changes

antfu changed the title ~~feat(reporter): KiB instead of kb unit~~ chore: KiB instead of kb unit Aug 5, 2021

antfu merged commit 66060ea into vitejs:main Aug 5, 2021

Mesteery deleted the patch-2 branch August 5, 2021 23:35

aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021

chore: KiB instead of kb unit (vitejs#4493)

55fccf3

patak-cat mentioned this pull request Nov 18, 2022

feat(build): Use kB in build reporter #10982

Merged

Provide feedback