Skip to content

docs(hmr): document hmr.server option (fix #3587)#3590

Merged
antfu merged 3 commits intovitejs:mainfrom
JBusillo:main
May 30, 2021
Merged

docs(hmr): document hmr.server option (fix #3587)#3590
antfu merged 3 commits intovitejs:mainfrom
JBusillo:main

Conversation

@JBusillo
Copy link
Contributor

@JBusillo JBusillo commented May 29, 2021

Description

Document the server.hmr.server configuration option. Fixes #3587

Additional context

Feel free to suggest alternate wording.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu previously approved these changes May 29, 2021
@antfu antfu merged commit a30724c into vitejs:main May 30, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
* docs(hmr): document hmr.server option

* docs(hmr): hmr.server apply suggestions
@benmccann
Copy link
Collaborator

The PR description should have said Fixes #3587

@JBusillo
Copy link
Contributor Author

JBusillo commented Jun 1, 2021

OK. Changed description accordingly.

@bluwy bluwy mentioned this pull request Mar 13, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation lacks server.hmr.server config parameter

3 participants