fix(server): hostname defaults to localhost, fix #3355#3383
Merged
antfu merged 6 commits intovitejs:mainfrom May 12, 2021
patak-cat:fix/hostname-rework
Merged
fix(server): hostname defaults to localhost, fix #3355#3383antfu merged 6 commits intovitejs:mainfrom patak-cat:fix/hostname-rework
antfu merged 6 commits intovitejs:mainfrom
patak-cat:fix/hostname-rework
Conversation
9 tasks
Shinigami92
reviewed
May 12, 2021
nihalgonsalves
previously approved these changes
May 12, 2021
Member
nihalgonsalves
left a comment
There was a problem hiding this comment.
I like this structure 👍🏼 It's more understandable now, and there aren't replacements in different places.
Co-authored-by: Nihal Gonsalves <nihal@nihalgonsalves.com>
Co-authored-by: Nihal Gonsalves <nihal@nihalgonsalves.com>
nihalgonsalves
approved these changes
May 12, 2021
Shinigami92
approved these changes
May 12, 2021
antfu
approved these changes
May 12, 2021
fi3ework
pushed a commit
to fi3ework/vite
that referenced
this pull request
May 22, 2021
…3383) Co-authored-by: Nihal Gonsalves <nihal@nihalgonsalves.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rework of #3382, avoiding replacing
'127.0.0.1'by'localhost'if this was defined by the user usinghostIt also fixes
options.host === false.The hint to use
hostin the console is not shown if the user sets127.0.0.1by hand.Fix #3355
After #2977, we lost the hostname defaulting to localhost for
'127.0.0.1'and'0.0.0.0'vite/packages/vite/src/node/server/index.ts
Line 536 in c374a54
This PR adds that logic back, also including
host === undefinedand'::'that should be treated equally to '0.0.0.0'The reported URL in the console also replaces
'127.0.0.1'by localhost now.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).--
Replaces + closes #3382