Skip to content

fix(css): fix sass importer error#3368

Merged
antfu merged 2 commits intovitejs:mainfrom
bsunderhus:fix-sass-importer
May 12, 2021
Merged

fix(css): fix sass importer error#3368
antfu merged 2 commits intovitejs:mainfrom
bsunderhus:fix-sass-importer

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented May 11, 2021

close #3180

Description

This PR Solves #3180, adding a simple mechanism to enable the usage of importer through preprocessorOptions in css configuration options.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels May 12, 2021
underfin
underfin previously approved these changes May 12, 2021
Co-authored-by: patak <matias.capeletto@gmail.com>
@patak-cat patak-cat requested a review from underfin May 12, 2021 17:14
@antfu antfu merged commit 3f04abf into vitejs:main May 12, 2021
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Co-authored-by: patak <matias.capeletto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: css p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Establish a mechanism that can intervene in the sass / scss importer

5 participants