fix(emptyOutDir): never remove .git#3043
Merged
aleclarson merged 1 commit intovitejs:mainfrom Apr 26, 2021
Merged
Conversation
..and empty the out dir in `build --watch` mode when `emptyOutDir` is null.
patak-cat
approved these changes
Apr 19, 2021
6 tasks
6 tasks
Member
|
See #3145 that also fixes this issue while replacing rollup watch with chokidar. We could still merge this fix though in the meantime. |
9 tasks
TobiasMelen
pushed a commit
to TobiasMelen/vite
that referenced
this pull request
May 3, 2021
..and empty the out dir in `build --watch` mode when `emptyOutDir` is null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If
.gitexists in the root ofoutDir, assume the user doesn't want it removed. The rationale is that Vite never generates.gitfor the user, so it should leave it alone.This PR also contains a fix related to
emptyOutDirwhen the--watchflag is used in build mode. Previously, theoutDirwould not be emptied before Rollup rebuilds ifemptyOutDirwas null. Now it is emptied.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).