Skip to content

fix: don't resolve import using browser during SSR (fix #2995)#2996

Merged
patak-cat merged 1 commit intovitejs:mainfrom
benmccann:ssr-browser
Apr 15, 2021
Merged

fix: don't resolve import using browser during SSR (fix #2995)#2996
patak-cat merged 1 commit intovitejs:mainfrom
benmccann:ssr-browser

Conversation

@benmccann
Copy link
Collaborator

@benmccann benmccann commented Apr 15, 2021

Description

The browser field should not be resolved for SSR

Additional context

Closes #2995

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-cat patak-cat requested a review from Shinigami92 April 15, 2021 06:51
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 15, 2021
@patak-cat patak-cat merged commit fd1c9ba into vitejs:main Apr 15, 2021
@ixxie
Copy link

ixxie commented Apr 15, 2021

Thanks for merging this rapidly; when can I expect this to be released, more or less?

@Shinigami92
Copy link
Member

Shinigami92 commented Apr 15, 2021

Mostly the next upcoming weekend, but don't pin me on that 🙂

@ixxie
Copy link

ixxie commented Apr 15, 2021

Cheers @Shinigami92, I'll keep my eyes peeled :D

@stupidawesome stupidawesome mentioned this pull request Apr 18, 2021
Closed
This was referenced Apr 21, 2021
Merged
Closed
Merged
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
@benmccann @TobiasMelen
fix: don't resolve import using browser during SSR (fix vitejs#2995) (v…
51d0e55 
…itejs#2996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

+1 more reviewer

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vite resolves import with browser field during SSR

4 participants

@benmccann @ixxie @Shinigami92 @patak-cat