feat: implement custom logger#2521
Merged
patak-cat merged 6 commits intovitejs:mainfrom Aug 2, 2021
stingalleman:feat/custom-logger
Merged
feat: implement custom logger#2521patak-cat merged 6 commits intovitejs:mainfrom stingalleman:feat/custom-logger
patak-cat merged 6 commits intovitejs:mainfrom
stingalleman:feat/custom-logger
Conversation
Shinigami92
reviewed
Mar 21, 2021
Shinigami92
reviewed
May 28, 2021
Shinigami92
previously approved these changes
May 28, 2021
Member
|
@stingalleman Can you explain a bit more about why you want this feature? We would like to keep our config interface as minimal as possible, and from our team aspect, we didn't yet see many use cases of providing custom logger here. Thanks. |
Contributor
Author
|
@antfu We run our developer environment in Docker, and the problem is that all the logs are shown at once, and it's just a nice visual addition if Vite uses the same format as the other loggers, which are all the same. |
antfu
approved these changes
Aug 2, 2021
Shinigami92
approved these changes
Aug 2, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Sep 30, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a way to use your own logger.
You just need to make a class that implements the already exported class
Loggerand inject it in the config.A really quick and ugly example:
will result in: