Skip to content

feat: add inlineConfig.envFile option to disable .env files#2475

Merged
patak-cat merged 1 commit into
vitejs:mainfrom
egoist-bot:disable-env
Apr 14, 2021
Merged

feat: add inlineConfig.envFile option to disable .env files#2475
patak-cat merged 1 commit into
vitejs:mainfrom
egoist-bot:disable-env

Conversation

@egoist

@egoist egoist commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

This feature is primarily for frameworks that use Vite under the hood:

  • Frameworks might need to load .env before starting Vite dev server, so they use the loadEnv function provided by Vite.
  • Vite loads .env again when it's unnecessary
  • Vite restarts when .env changes but this should be left to user in this case

@egoist

egoist commented Mar 11, 2021

Copy link
Copy Markdown
Contributor Author

Tests work locally, but somehow it failed on circleci.

@antfu

antfu commented Mar 13, 2021

Copy link
Copy Markdown
Member

Failure is unrelated.

@antfu antfu added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 13, 2021
@antfu antfu requested a review from yyx990803 April 4, 2021 03:52
@antfu antfu requested a review from patak-cat April 14, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants