fix: preserve transform metadata in build hooks#22765
Closed
TheAlexLichter wants to merge 2 commits into
Closed
Conversation
Member
|
I think |
Member
Author
|
Will submit a fix in Rolldown then 👍🏻 |
hyf0
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Jun 27, 2026
This is more my alley :D These properties should be `enumerable` (oversight that they aren't). Otherwise they don't behave like normal JS objects and they are not listed when spreading or using `Object.keys` (and others). Related: vitejs/vite#22765
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Vite’s
buildhook wrapper so adding the Vitessrflag no longer drops non-enumerable Rolldown transform metadata likemagicString.Otherwise, https://github.com/unjs/unplugin and other consumers are not able to use them easily.
A focused regression test for Vite’s wrapper behavior is included.