feat(types): add more precise typing for known `query` types to match known `as` types by nathanhleung · Pull Request #21863 · vitejs/vite

nathanhleung · 2026-03-14T22:01:13Z

Summary

In Vite 5.1 (released Feb 8, 2024), the as option in the import.meta.glob function was deprecated. The official recommendation was to switch to the query option, e.g.:

const myGlobImports = import.meta.glob("./path/*.csv", {
-  as: "raw",
+  query: "?raw",
  eager: true,
  import: "default",
});

Unfortunately, this loses some type information; specifically, TypeScript infers myGlobImports as Record<string, unknown> instead of Record<string, string> (or a Record pointing to Promises returning unknown or string, respectively, if eager is false) after making this change. The reason for this is because importGlob.d.ts does not have an overload which infers the type of the import from query when possible; there is only an overload which infers the type from as.

Changes

This PR adds an overload in importGlob.d.ts that matches the logic of the existing as overload but works with query, allowing users to migrate from as to query when using import.meta.glob without losing type information (the current workaround is unsafely casting with as unknown as Record<string, string>).

Tests?

I've applied this patch to an internal project and it seems to be working; I've tested with eager both true and false and swapping between as and query (the new overload needs to go above the previous overload because it is more specific and TypeScript applies overloads top-to-bottom).

I didn't see a way to test these types other than running pnpm build (which runs pnpm build-types internally) — for what it's worth, the local build did complete without errors. Let me know if there is anything else I can do to test.

…nown as types

sapphi-red

I think we can have this.

Would you add type tests like these?

vite/packages/vite/src/node/__tests_dts__/utils.ts

Line 49 in dbe41bd

ExpectTrue<Equal<typeof useDefaultTypeForUndefined1, { foo: number }>>,

nathanhleung · 2026-03-17T03:05:27Z

Would you add type tests like these?

vite/packages/vite/src/node/__tests_dts__/utils.ts

Line 49 in dbe41bd

ExpectTrue<Equal<typeof useDefaultTypeForUndefined1, { foo: number }>>,

I created a new file importGlob.ts in the same directory and added some tests there, including coverage for the existing as overload. If these tests should be placed in another location, let me know and I can move.

nathanhleung · 2026-04-04T00:40:03Z

Friendly ping here, anything else I could do on my side to help move this along? cc @sapphi-red

sapphi-red · 2026-06-03T05:02:00Z

/ecosystem-ci run

pkg-pr-new · 2026-06-03T05:03:46Z

Open in StackBlitz

@vitejs/plugin-legacy

pnpm add https://pkg.pr.new/@vitejs/plugin-legacy@21863 -D

npm i https://pkg.pr.new/@vitejs/plugin-legacy@21863 -D

yarn add https://pkg.pr.new/@vitejs/plugin-legacy@21863.tgz -D

vite

pnpm add https://pkg.pr.new/vite@21863 -D

npm i https://pkg.pr.new/vite@21863 -D

yarn add https://pkg.pr.new/vite@21863.tgz -D

commit: a54925b

vite-ecosystem-ci · 2026-06-03T05:31:05Z

📝 Ran ecosystem CI on 02a2f55: Open

suite	result	latest scheduled
astro	❌ failure	❌ failure
marko	✅ success	❌ failure
tanstack-start	❌ failure	❌ failure
vite-plugin-cloudflare	❌ failure	❌ failure
vitest	❌ failure	❌ failure

✅ analogjs, sveltekit, react-router, qwik, laravel, storybook, quasar, module-federation, nuxt, vite-plugin-rsc, vite-plugin-vue, vite-plugin-pwa, vitepress, vite-environment-examples, vite-plugin-react, waku, vite-setup-catalogue, vuepress, vite-plugin-svelte, vike, unocss

…nvs) Vite reports its inputs/outputs/envs to the `vp` runner via `@voidzero-dev/vite-task-client`, so `vp build` no longer needs a hand-synthesized cache config. - Bump vite-task git deps to c44d7c33 (runner-aware IPC server/client + embedded napi addon); regenerate run-config.ts for the new task-config types. - Point the vite behind vp build/vp dev to latest vitejs/vite (c13a37b53), which carries the vite-task-client integration. vite lists vite-task-client in devDependencies, so it is bundled into vite's output (and thus into core) the same way as vite's other bundled deps (cac, esbuild, ...) — no extra dependency or build wiring needed. - Work around an upstream vite dts bug (vitejs/vite#21863): `node/index.ts` re-exports `KnownQueryTypeMap` but the type is declared without `export`, which breaks downstream type bundling (`vp build` MISSING_EXPORT). core's build adds the missing `export` when copying vite's type defs. - Remove vp build's synthetic cache config (env: [VITE_*], manual input excludes). All-None EnabledCacheConfig keeps caching enabled with auto input/output inference (output restoration); vp dev stays disabled. - Snap tests: vp-build-auto-output-restoration, vp-build-auto-tracked-env. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

feat(types): add more precise typing for known query types to match k…

df6f4ab

…nown as types

sapphi-red reviewed Mar 16, 2026

View reviewed changes

sapphi-red added the p2-to-be-discussed Enhancement under consideration (priority) label Mar 16, 2026

sapphi-red added this to Team Board Mar 16, 2026

github-project-automation Bot moved this to Discussing in Team Board Mar 16, 2026

sapphi-red moved this from Discussing to P2 - 3 in Team Board Mar 16, 2026

nathanhleung added 2 commits March 16, 2026 22:56

feat(types): export KnownQueryTypeMap to match KnownAsTypeMap export

21e5632

test(types): add type tests for new query overload

f003b68

nathanhleung requested a review from sapphi-red March 17, 2026 03:24

sapphi-red moved this from P2 - 3 to Approved in Team Board Apr 29, 2026

sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) and removed p2-to-be-discussed Enhancement under consideration (priority) labels Jun 3, 2026

sapphi-red and others added 2 commits June 3, 2026 13:04

Merge branch 'main' into nathanhleung/import-glob-types

3b44c5a

chore: tweak

a54925b

vite-ecosystem-ci Bot added the trigger: preview label Jun 3, 2026

sapphi-red approved these changes Jun 3, 2026

View reviewed changes

sapphi-red merged commit cc39e55 into vitejs:main Jun 3, 2026
19 of 20 checks passed

nathanhleung deleted the nathanhleung/import-glob-types branch June 3, 2026 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(types): add more precise typing for known `query` types to match known `as` types#21863

feat(types): add more precise typing for known `query` types to match known `as` types#21863
sapphi-red merged 5 commits into
vitejs:mainfrom
nathanhleung:nathanhleung/import-glob-types

nathanhleung commented Mar 14, 2026

Uh oh!

sapphi-red left a comment

Uh oh!

nathanhleung commented Mar 17, 2026 •

edited

Loading

Uh oh!

nathanhleung commented Apr 4, 2026

Uh oh!

sapphi-red commented Jun 3, 2026

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026

Uh oh!

vite-ecosystem-ci Bot commented Jun 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

nathanhleung commented Mar 14, 2026

Summary

Changes

Tests?

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

nathanhleung commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nathanhleung commented Apr 4, 2026

Uh oh!

sapphi-red commented Jun 3, 2026

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026

Uh oh!

vite-ecosystem-ci Bot commented Jun 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nathanhleung commented Mar 17, 2026 •

edited

Loading