Skip to content

refactor: use rolldownOptions where possible#21205

Merged
sapphi-red merged 23 commits into
vitejs:mainfrom
TheAlexLichter:rollupOptions
Jun 2, 2026
Merged

refactor: use rolldownOptions where possible#21205
sapphi-red merged 23 commits into
vitejs:mainfrom
TheAlexLichter:rollupOptions

Conversation

@TheAlexLichter

Copy link
Copy Markdown
Member

Description

Replaces all legacy rollupOptions calls with rolldownOptions (except compat layer)

@TheAlexLichter TheAlexLichter marked this pull request as draft December 3, 2025 17:28
@TheAlexLichter TheAlexLichter marked this pull request as ready for review December 18, 2025 07:12
@bluwy

bluwy commented Mar 6, 2026

Copy link
Copy Markdown
Member

@TheAlexLichter are you still interested in updating and resolving the conflicts? Happy to review after that.

@TheAlexLichter

Copy link
Copy Markdown
Member Author

Yes, let me check!

@TheAlexLichter TheAlexLichter self-assigned this Mar 6, 2026
@TheAlexLichter TheAlexLichter requested a review from bluwy April 29, 2026 20:23

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs and code changes largely looks good to me. But I'd revert the package.json sorting though, and there's a type issue in CI

Comment thread packages/vite/src/node/build.ts Outdated
Comment thread packages/vite/src/node/utils.ts Outdated
Comment thread packages/vite/src/node/config.ts Outdated
@TheAlexLichter TheAlexLichter requested a review from bluwy May 7, 2026 05:52
bluwy
bluwy previously approved these changes May 7, 2026

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for following up on this.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 11, 2026
@sapphi-red sapphi-red self-requested a review May 11, 2026 04:50
@sapphi-red sapphi-red added this to the 8.1 milestone May 11, 2026
Comment thread packages/vite/src/node/plugins/worker.ts Outdated
Comment thread packages/vite/src/node/plugins/worker.ts Outdated
@sapphi-red

Copy link
Copy Markdown
Member

/ecosystem-ci run

@pkg-pr-new

pkg-pr-new Bot commented Jun 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/plugin-legacy

pnpm add https://pkg.pr.new/@vitejs/plugin-legacy@21205 -D
npm i https://pkg.pr.new/@vitejs/plugin-legacy@21205 -D
yarn add https://pkg.pr.new/@vitejs/plugin-legacy@21205.tgz -D

vite

pnpm add https://pkg.pr.new/vite@21205 -D
npm i https://pkg.pr.new/vite@21205 -D
yarn add https://pkg.pr.new/vite@21205.tgz -D

commit: ee257c3

@vite-ecosystem-ci

Copy link
Copy Markdown

@sapphi-red sapphi-red merged commit 7ca7c1b into vitejs:main Jun 2, 2026
38 of 40 checks passed
@vite-ecosystem-ci

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority) trigger: preview

Projects

None yet

3 participants