Description
PR #22400 ("fix: refer to rolldownOptions instead of deprecated rollupOptions in messages") fixed most user-facing references to the deprecated rollupOptions name, but three occurrences of rollupOptions.input in packages/vite/src/node/build.ts were not updated.
Affected version
vite@8.0.14 and current main branch
Affected file
packages/vite/src/node/build.ts
1. JSDoc comment (line 260) — shown as IDE hover tooltip for build.ssr:
/**
* Produce SSR oriented build. Note this requires specifying SSR entry via
* `rollupOptions.input`. // ← should be rolldownOptions.input
*/
ssr?: boolean | string
2. Runtime error message (line 604) — thrown when an .html file is passed as SSR entry:
`rollupOptions.input should not be an html file when building for SSR. ` +
`Please specify a dedicated SSR entry.`,
3. Runtime error message (line 617) — thrown when build.cssCodeSplit: false and CSS files are in input:
`When "build.cssCodeSplit: false" is set, "rollupOptions.input" should not include CSS files.`,
Inconsistency with PR #22400
PR #22400 updated the following in the same file:
| Fixed by #22400 |
Not updated |
rollupOptions.output.output |
rollupOptions.input (line 260, 604, 617) |
rollupOptions.output.file |
|
rollupOptions.output.sourcemap |
|
rollupOptions.external |
|
Open question
Were these three occurrences intentionally left as-is (e.g. because users hitting these errors are likely using rollupOptions directly), or were they simply not covered by #22400?
If updating them is appropriate, the fix would be to replace rollupOptions.input with rolldownOptions.input in the three locations above. Happy to submit a PR once confirmed.
Description
PR #22400 ("fix: refer to
rolldownOptionsinstead of deprecatedrollupOptionsin messages") fixed most user-facing references to the deprecatedrollupOptionsname, but three occurrences ofrollupOptions.inputinpackages/vite/src/node/build.tswere not updated.Affected version
vite@8.0.14and currentmainbranchAffected file
packages/vite/src/node/build.ts1. JSDoc comment (line 260) — shown as IDE hover tooltip for
build.ssr:2. Runtime error message (line 604) — thrown when an
.htmlfile is passed as SSR entry:3. Runtime error message (line 617) — thrown when
build.cssCodeSplit: falseand CSS files are in input:Inconsistency with PR #22400
PR #22400 updated the following in the same file:
rollupOptions.output.outputrollupOptions.input(line 260, 604, 617)rollupOptions.output.filerollupOptions.output.sourcemaprollupOptions.externalOpen question
Were these three occurrences intentionally left as-is (e.g. because users hitting these errors are likely using
rollupOptionsdirectly), or were they simply not covered by #22400?If updating them is appropriate, the fix would be to replace
rollupOptions.inputwithrolldownOptions.inputin the three locations above. Happy to submit a PR once confirmed.