Skip to content

feat(createLogger): allow custom prefix for logger#2019

Merged
antfu merged 4 commits intovitejs:mainfrom
antfu:feat/custom-create-logger
Apr 17, 2021
Merged

feat(createLogger): allow custom prefix for logger#2019
antfu merged 4 commits intovitejs:mainfrom
antfu:feat/custom-create-logger

Conversation

@antfu
Copy link
Member

@antfu antfu commented Feb 14, 2021

So it can be resued by community plugins to have the uniformed log outputs.

Shinigami92
Shinigami92 previously approved these changes Mar 23, 2021
@Shinigami92 Shinigami92 added p2-nice-to-have Not breaking anything but nice to have (priority) enhancement New feature or request 🔍 review needed labels Mar 23, 2021
patak-cat
patak-cat previously approved these changes Mar 23, 2021
@antfu antfu dismissed stale reviews from patak-cat and Shinigami92 via c1ed66c April 17, 2021 23:20
@antfu antfu requested review from Shinigami92 and patak-cat April 17, 2021 23:20
@antfu
Copy link
Member Author

antfu commented Apr 17, 2021

Resolved the conflicts

@antfu
Copy link
Member Author

antfu commented Apr 17, 2021

Guess we can merge this as I think making the second argument into options make it more extensible for future additions.

@antfu antfu merged commit 344d77e into vitejs:main Apr 17, 2021
@antfu antfu deleted the feat/custom-create-logger branch April 17, 2021 23:45
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
@patak-cat patak-cat mentioned this pull request Sep 18, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants