Skip to content

fix(resolve): preserve hash/search of file url#19300

Merged
patak-cat merged 2 commits intovitejs:mainfrom
hi-ogawa:fix-file-url-hash-search
Feb 3, 2025
Merged

fix(resolve): preserve hash/search of file url#19300
patak-cat merged 2 commits intovitejs:mainfrom
hi-ogawa:fix-file-url-hash-search

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa marked this pull request as ready for review February 2, 2025 09:53
@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels Feb 3, 2025
@patak-cat patak-cat merged commit d1e1b24 into vitejs:main Feb 3, 2025
17 checks passed
@hi-ogawa hi-ogawa deleted the fix-file-url-hash-search branch February 3, 2025 23:30
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Apr 23, 2025
<!-- Thank you for contributing! -->

### Description

Ported changes from the following PRs:

- vitejs/vite#18889
- vitejs/vite#19300
- vitejs/vite#18584,
vitejs/vite#19312

and some minor changes.

With this PR and #4270, the tests in Vite repo should now pass with
native resolve plugin.

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Apr 23, 2025
<!-- Thank you for contributing! -->

### Description

Ported changes from the following PRs:

- vitejs/vite#18889
- vitejs/vite#19300
- vitejs/vite#18584,
vitejs/vite#19312

and some minor changes.

With this PR and #4270, the tests in Vite repo should now pass with
native resolve plugin.

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ssrLoadModule returns an identical module for file urls with hash/search

3 participants